Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: mephit and character ID changes should be supported #174

Open
AdmiralGT opened this issue Jun 7, 2022 · 0 comments
Open

Feature: mephit and character ID changes should be supported #174

AdmiralGT opened this issue Jun 7, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@AdmiralGT
Copy link
Owner

In an attempt to parse information to display on the script page, the ID is looked up in the Character "database" https://github.com/AdmiralGT/botc-scripts/blob/main/scripts/characters.py

Sadly, mephit is not included in this list and so is ignored. However, this means that it is ignored from the statistics page, is displayed poorly on script pages.

I suspect the fix here is to move these characters to the database and then additional information can easily be stored about them e.g. that mephit is the same as mezepheles. Although this could likely also be covered by updating the hard coded information currently available.

@AdmiralGT AdmiralGT added the enhancement New feature or request label Jun 7, 2022
@AdmiralGT AdmiralGT self-assigned this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant