U/edgarivanv/fix false positives and not resolving nonindex files #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjective-Object
approved these changes
Aug 28, 2023
| * References to symbols from the node api require | ||
| * linking to a real instance of node, which means that | ||
| * `cargo test` can't link anything | ||
| */ |
There was a problem hiding this comment.
Why'd this module-level comment get deleted?
src/unused_finder/mod.rs
Outdated
| } | ||
| ResolvedItem::Exported(exported_item) => { | ||
| used_items.insert(exported_item.clone()); | ||
| .for_each(|(_path, imported_things)| { |
There was a problem hiding this comment.
imported_things imprecise name
…e into u/edgarivanv/fix-false-positives-and-not-resolving-nonindex-files
…s for linxu/windows/darwin releases
flickyiyo
deleted the
u/edgarivanv/fix-false-positives-and-not-resolving-nonindex-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed validations done to check if item was being unused.
import 'foo'is being executed.NapiLikeErrorsince newer versions of rust enforce that forResult::Error.swcthat simplifies the dependency graph to only useswc_coreandswc_ecmascript.resolve_ts_importthat marked import paths such as./Foo.baseasResourceImportinstead to the referred file./Foo.base.tswhich is a LocalProjectImport.unused.jsto test the tool on client web, also, added the list of entry points in client web.