Skip to content

Commit

Permalink
[Regression] - Fixing Docker setup regression in yarn install comma…
Browse files Browse the repository at this point in the history
…nd (oppia#19054)

* mathjs issue

* checking for pure-lockfile flag

* checking for pure-lockfile flag

* fixing mathjs issue
  • Loading branch information
Shivkant-Chauhan authored Oct 27, 2023
1 parent 53ffe8d commit acf840d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ update.package: ## Installs the npm requirements for the project
# TODO(#18260): Permanently change the yarn configurations in `.yarnrc` when permanently moving to Docker Setup.
# Creating a .yarnrc file to use yarn under docker
@echo 'cache-folder "/root/.yarn-cache"' > .yarnrc
${SHELL_PREFIX} angular-build yarn install
${SHELL_PREFIX} angular-build yarn install --pure-lockfile
# Reverting the .yarnrc file to the original state, so that it works in python setup also.
@echo 'yarn-path "../oppia_tools/yarn-1.22.15/bin/yarn"' > .yarnrc
@echo 'cache-folder "../yarn_cache"' >> .yarnrc
Expand Down
3 changes: 2 additions & 1 deletion docker/Dockerfile.frontend
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ RUN apt-get update -y && apt-get upgrade -y \
COPY package.json .
COPY scripts/linters/custom_eslint_checks ./scripts/linters/custom_eslint_checks

COPY yarn.lock .
RUN npm install -g [email protected] --force
RUN yarn install
RUN yarn install --pure-lockfile

0 comments on commit acf840d

Please sign in to comment.