Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'prevent-eval-if' — return original value for 'eval.toString()' #481

Closed
AdamWr opened this issue Feb 14, 2025 · 2 comments
Closed

Fix 'prevent-eval-if' — return original value for 'eval.toString()' #481

AdamWr opened this issue Feb 14, 2025 · 2 comments
Assignees
@AdamWr
Labels
bug Something isn't working Priority: P4 Release: v2.1.5 Resolution: Fixed Status: Closed Version: Scriptlets v2.1

Comments

@AdamWr
Copy link
Member

AdamWr commented Feb 14, 2025 •
edited
Loading

It seems that prevent-eval-if breaks Cloudflare captcha now, related issue - AdguardTeam/AdguardFilters#198508, but there are more broken websites.
It looks like the problem is that captcha is broken when eval.toString() does not return original value.
So we could change it.

The same for prevent-bab.
@adguard-bot adguard-bot assigned AdamWr and unassigned maximtop Feb 14, 2025
@MasterKia MasterKia mentioned this issue Feb 14, 2025
Open
adguard pushed a commit that referenced this issue Feb 17, 2025
@AdamWr
AG-39948 Improve 'prevent-eval-if' — return original value for 'eval.…
60053cb 
…toString()'. #481

Squashed commit of the following:

commit ad2685c
Merge: 568bdd0 9a97415
Author: Adam Wróblewski <[email protected]>
Date:   Mon Feb 17 12:02:51 2025 +0100

    Merge branch 'master' into fix/AG-39948

commit 568bdd0
Author: Adam Wróblewski <[email protected]>
Date:   Mon Feb 17 11:56:32 2025 +0100

    Fix prevent-bab

commit 236d6a4
Author: Adam Wróblewski <[email protected]>
Date:   Fri Feb 14 19:45:28 2025 +0100

    Update changelog

commit 8967d9b
Author: Adam Wróblewski <[email protected]>
Date:   Fri Feb 14 19:00:04 2025 +0100

    Improve 'prevent-eval-if' — return original value for 'eval.toString()'
@Alex-302
Copy link
Member

prevent-bab is also affected. Could you please take a look?

@AdamWr
Copy link
Member Author

AdamWr commented Feb 27, 2025

prevent-bab has been fixed in the same commit as prevent-eval-if - 60053cb#diff-510dbc36a0e0c08c23c9871223d65a2d98d00c8809ab1371fd64250f440ef786R96

@adguard-bot adguard-bot changed the title Improve 'prevent-eval-if' — return original value for 'eval.toString()' Fix 'prevent-eval-if' — return original value for 'eval.toString()' Feb 28, 2025
@slavaleleka slavaleleka added the bug Something isn't working label Feb 28, 2025
This was referenced Mar 5, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdamWr AdamWr

Labels
bug Something isn't working Priority: P4 Release: v2.1.5 Resolution: Fixed Status: Closed Version: Scriptlets v2.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Alex-302 @maximtop @AdamWr @adguard-bot @slavaleleka