Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websockets are broken on old versions of Chrome #273

Closed
Alex-302 opened this issue Jun 20, 2016 · 11 comments
Closed

websockets are broken on old versions of Chrome #273

Alex-302 opened this issue Jun 20, 2016 · 11 comments
Assignees
Milestone

Comments

@Alex-302
Copy link
Member

Alex-302 commented Jun 20, 2016

For example:

https://forum.adguard.com/index.php?threads/adguard-%D0%B8-privat24.11219/
without extension

![image](http://imagizer.imageshack.com/img921/3608/QX3tLC.png)
with extension
![image](http://imagizer.imageshack.com/img923/776/wJtp92.png)
websocket wss://www.privat24.ua/ws/sr - slack.com can't connect with enabled extension. This issue can't be fixed by filters.

Tested on Slimjet 6.0.11.0 (based on Chromium 46.0.2490.71)
Browser:
https://mega.nz/#!AVdHXbaQ!UZDPIzpo_S17pxs2luTvXbOG39KgNHasfTEeNyiZNlU

@Alex-302
Copy link
Member Author

Maybe the same issue.
Extension for Chrome 2.3.8, Chrome 51
Checked even without filters.
URL:
https://poloniex.com/exchange
Extension is enabled:

![s](http://imagizer.imageshack.com/img921/7397/CQ8nVC.png) ![s](http://imagizer.imageshack.com/img923/6206/IpZ0l0.png)
Extension is disabled:
![s](http://imagizer.imageshack.com/img923/4834/mcFe8o.png) ![s](http://imagizer.imageshack.com/img922/3086/yvgcpg.png)

@ameshkov
Copy link
Member

@Mizzick please take a look at this issue, seems to be broken in new Chrome

@Mizzick
Copy link
Contributor

Mizzick commented Jul 11, 2016

So, any ideas how can we fix this?

@ameshkov
Copy link
Member

Have you tested it?

@Mizzick
Copy link
Contributor

Mizzick commented Jul 11, 2016

var c = window.WebSocket,
   d = document.createElement("iframe");

d.style.display = "none";
document.documentElement.appendChild(d);
if (d.contentWindow.WebSocket) {
   c = d.contentWindow.WebSocket
}
c
WebSocket() { [native code] }

@ameshkov
Copy link
Member

There is nothing we can do with this I guess.

This issue is about broken WebSocket, is it the same issue?

Mizzick added a commit that referenced this issue Jul 12, 2016
@Mizzick
Copy link
Contributor

Mizzick commented Jul 12, 2016

gorhill/uBO-Extra#4

@ameshkov
Copy link
Member

@Mizzick don't forget the MS Edge manifest

@ameshkov ameshkov reopened this Jul 12, 2016
Mizzick added a commit that referenced this issue Jul 12, 2016
@Mizzick
Copy link
Contributor

Mizzick commented Jul 12, 2016

Yeap

@Mizzick Mizzick closed this as completed Jul 12, 2016
@ameshkov
Copy link
Member

So the problem with Slimjet is fixed now?

ameshkov added a commit that referenced this issue Jul 15, 2016
Mizzick added a commit that referenced this issue Jul 18, 2016
@Mizzick
Copy link
Contributor

Mizzick commented Jul 18, 2016

Yeap

ameshkov pushed a commit that referenced this issue Dec 28, 2018
…to feature/redesign

* commit '76bda2a950dfacef3b7a8ce2b5270c965e93d39d':
  fix/953
  fix/953
  fix/953
  fix/953 update area-checked attribute on iteractions with checkboxes
  fix/953
  temp save
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants