Format values in Setting clients #7583
Merged
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! I'll ask the frontend team to review it. |
|
Thank you! If you notice any code or anything that seems inappropriate, feel free to point it out to me at any time. |
adguard
pushed a commit
that referenced
this pull request
Feb 24, 2025
Updates #7583. * commit 'e9d4e76828261622dfb424c760246a21b73040e8': all: upd chlog refactor: Format value requests_count on client table refactor: Format value clientstats
adguard
pushed a commit
that referenced
this pull request
Feb 26, 2025
Updates #7583. * commit 'cd5dd1eb167d9bca014b2ff45f6826e7969d7b5c': refactor: fix conditional check for content formatting in statistics column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the content displayed in AutoClient.tsx and ClientsTable.tsx to use a formatted number.
Changes:
2.Applied formatNumber to numeric values in the Cell method to ensure consistent formatting.
Since I noticed that this PR #7505 introduces a function for formatting numeric display and applies it only to the homepage, I’ve extended its usage to also format numbers in the Setting Clients section to improve readability.
Thank you.