Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hasBlock usage with has-block helper #884

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

kpfefferle
Copy link
Member

Ember 3.26 introduces a deprecation for hasBlock in favor of (has-block):

I was curious how easy this would be to address in ember-table, so this branch tries out the simple find-and-replace. It appears to pass all test scenarios except Ember 2.8. I'm not sure there's a polyfill for this (I'm not immediately finding one) to get us compatible back to 2.8, so maybe we just need to sit on it until we're ready to drop 2.8 compat - which I trust would happen before 4.0 drops the deprecated option?

@twokul
Copy link
Contributor

twokul commented Mar 24, 2021

I think it is okay to hold off merging this PR until we drop Ember 2.8 as a target officially.

@RobbieTheWagner
Copy link
Contributor

@kpfefferle @twokul We are getting a bunch of hasBlock deprecations in Ember Inspector, and I believe ember-table is the culprit. Any idea when this could be merged? Perhaps we could work on a next branch and support all the new things?

@ghost
Copy link

ghost commented Nov 15, 2021

I think it is okay to hold off merging this PR until we drop Ember 2.8 as a target officially.

When do we think this will happen? I stumbled upon this when upgrading my app -- trying to get to Ember 3.26 and seeing warnings coming from latest ember-table.

@RobbieTheWagner
Copy link
Contributor

@justinzelinsky you can use my fork, if you'd like https://github.com/rwwagner90/ember-table

@kpfefferle kpfefferle force-pushed the kpfefferle/has-block-deprecation branch from d5bacfa to b26ecef Compare December 3, 2021 15:25
@kpfefferle kpfefferle force-pushed the kpfefferle/has-block-deprecation branch from b26ecef to ce5f300 Compare December 3, 2021 15:34
@kpfefferle kpfefferle changed the base branch from master to 4.0-beta December 3, 2021 15:35
@kpfefferle
Copy link
Member Author

This PR has been changed to target the 4.0-beta branch since it requires dropping support for Ember 2.8

@kpfefferle kpfefferle requested a review from a team December 3, 2021 15:36
@RobbieTheWagner
Copy link
Contributor

@kpfefferle since we are targeting the new branch, is there any reason not to go ahead and merge? Everything looks good to me!

@mixonic mixonic merged commit 796e2c6 into 4.0-beta Dec 6, 2021
@mixonic mixonic deleted the kpfefferle/has-block-deprecation branch December 6, 2021 14:34
@mixonic
Copy link
Member

mixonic commented Dec 6, 2021

🎉 great to see this get started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants