-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hasBlock usage with has-block helper #884
Conversation
I think it is okay to hold off merging this PR until we drop Ember 2.8 as a target officially. |
@kpfefferle @twokul We are getting a bunch of |
When do we think this will happen? I stumbled upon this when upgrading my app -- trying to get to Ember 3.26 and seeing warnings coming from latest |
@justinzelinsky you can use my fork, if you'd like https://github.com/rwwagner90/ember-table |
d5bacfa
to
b26ecef
Compare
b26ecef
to
ce5f300
Compare
This PR has been changed to target the |
@kpfefferle since we are targeting the new branch, is there any reason not to go ahead and merge? Everything looks good to me! |
🎉 great to see this get started! |
Ember 3.26 introduces a deprecation for
hasBlock
in favor of(has-block)
:I was curious how easy this would be to address in ember-table, so this branch tries out the simple find-and-replace. It appears to pass all test scenarios except Ember 2.8. I'm not sure there's a polyfill for this (I'm not immediately finding one) to get us compatible back to 2.8, so maybe we just need to sit on it until we're ready to drop 2.8 compat - which I trust would happen before 4.0 drops the deprecated option?