(#349) android 10 gesture exclusion zone editor #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use customly-implemented SafeRectF for calculations instead of the regular RectF which has it's top and bottom coordinated flipped.
…k, top and bottom do not and there are couple of bugs)
…ture-zone-editor # Conflicts: # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/settings/ChanSettings.java # Kuroba/app/src/main/java/com/github/adamantcheese/chan/ui/controller/ExperimentalSettingsController.java # Kuroba/app/src/main/res/values/strings.xml
…ture-zone-editor # Conflicts: # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/settings/ChanSettings.java # Kuroba/app/src/main/java/com/github/adamantcheese/chan/ui/controller/ExperimentalSettingsController.java # Kuroba/app/src/main/res/values/strings.xml
…ture-zone-editor # Conflicts: # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/settings/ChanSettings.java # Kuroba/app/src/main/java/com/github/adamantcheese/chan/ui/controller/settings/ExperimentalSettingsController.java # Kuroba/app/src/main/res/values/strings.xml
- Fix a bug where an exclusion zone would not get deep copied which would result in the original zone being mutated which is unexpected.
K1rakishou
changed the title
…ture-zone-editor # Conflicts: # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/cache/FileCacheV2.kt # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/di/AppModule.java # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/di/ManagerModule.java # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/manager/ChanLoaderManager.java # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/presenter/ThreadPresenter.java # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/settings/ChanSettings.java # Kuroba/app/src/main/java/com/github/adamantcheese/chan/ui/controller/settings/MainSettingsController.java # Kuroba/app/src/main/java/com/github/adamantcheese/chan/ui/layout/ReportProblemLayout.kt # Kuroba/app/src/main/java/com/github/adamantcheese/chan/utils/AndroidUtils.java # Kuroba/app/src/main/res/values/colors.xml # Kuroba/app/src/main/res/values/strings.xml
...ava/com/github/adamantcheese/chan/features/gesture_editor/AdjustAndroid10GestureZonesView.kt
Outdated
Show resolved
Hide resolved
...ava/com/github/adamantcheese/chan/features/gesture_editor/AdjustAndroid10GestureZonesView.kt
Outdated
Show resolved
Hide resolved
...ava/com/github/adamantcheese/chan/features/gesture_editor/AdjustAndroid10GestureZonesView.kt
Outdated
Show resolved
Hide resolved
...ava/com/github/adamantcheese/chan/features/gesture_editor/AdjustAndroid10GestureZonesView.kt
Show resolved
Hide resolved
Kuroba/app/src/main/java/com/github/adamantcheese/chan/features/gesture_editor/SafeRectF.kt
Outdated
Show resolved
Hide resolved
...ava/com/github/adamantcheese/chan/features/gesture_editor/AdjustAndroid10GestureZonesView.kt
Show resolved
Hide resolved
...ava/com/github/adamantcheese/chan/features/gesture_editor/AdjustAndroid10GestureZonesView.kt
Show resolved
Hide resolved
...m/github/adamantcheese/chan/features/gesture_editor/Android10GesturesExclusionZonesHolder.kt
Outdated
Show resolved
Hide resolved
...m/github/adamantcheese/chan/features/gesture_editor/Android10GesturesExclusionZonesHolder.kt
Outdated
Show resolved
Hide resolved
...m/github/adamantcheese/chan/features/gesture_editor/Android10GesturesExclusionZonesHolder.kt
Show resolved
Hide resolved
…ture-zone-editor # Conflicts: # Kuroba/app/src/main/res/values/strings.xml
…ture-zone-editor # Conflicts: # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/settings/ChanSettings.java # Kuroba/app/src/main/res/values/strings.xml
…ture-zone-editor # Conflicts: # Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/settings/ChanSettings.java # Kuroba/app/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #349, #784