Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong thread sometimes opens #946

Closed
ghost opened this issue Jun 26, 2020 · 8 comments
Closed

Wrong thread sometimes opens #946

ghost opened this issue Jun 26, 2020 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jun 26, 2020

I think the app has a tendency to open recently opened threads instead of the one you tap on.
Just now I tried to open a thread in board mode and instead I got one that wasn't even on screen, and I had to scroll down quite a ways to find it. I did have the thread bookmarked, but it wasn't the thread I had open in split mode.

I'm using v4.12.0-d13de9f on a Samsung Note 10 Plus.

@Adamantcheese Adamantcheese added bug Something isn't working cantrepro Can't reproduce this issue labels Jun 26, 2020
@Adamantcheese
Copy link
Owner

Guess whenever it crops up again I'd like some more info.

@ghost
Copy link
Author

ghost commented Jun 27, 2020

I have no idea what causes it, but I really don't know how this could happen without some weird bug. If I had to guess, it would be that the thread stays highlighted as if you're still tapped on it when you go to the next thread and then it opens instead (or maybe after?).
I'm saying this because the same thing happened just now and the thread I wanted to open was highlighted, but so was the last thread I had tapped on.

@ghost
Copy link
Author

ghost commented Jun 27, 2020

Hmm, maybe I'm somehow tapping on two threads at the same time and recently opened threads aren't the main cause. Though maybe you're able to tap on a thread and a previous thread somehow.
In any case, it is possible to open two threads at once and not get the one you wanted, but that only explains half of my problem. Or I could just be crazy

@Adamantcheese
Copy link
Owner

Still can't reproduce it. Tapping two threads at once doesn't seem to cause any problems in slide mode. It might be a problem specific to split mode like how you've described if you tap two threads at the same time. Also it might be a problem if the site you're talking about is 2ch.hk, because that site has some serious API issues, although I don't think you're using that site.

I'll take a look at how cells get highlighted and try to figure out a reproduction method as well, since you said two threads in board mode were highlighted. Usually only one thread will be highlighted once you tap on it, unless you've made some other thread since all posts made by you are highlighted.

@Adamantcheese
Copy link
Owner

Update, can't cause it to happen in slide mode either, at least for 4chan. Highlighting doesn't lead me to any situations that would point me to a root cause. You're probably doing something strange, but I'll keep this open if you find a better method of reproduction. You can close the issue yourself if there's no actual bug, but otherwise I'll probably close this one out in a month's time or so.

@Adamantcheese Adamantcheese removed the cantrepro Can't reproduce this issue label Jun 27, 2020
@Adamantcheese
Copy link
Owner

Okay, so I did have it happen to me once, and the thread that reappeared was one that I had recently unpinned.

@Adamantcheese Adamantcheese self-assigned this Jun 27, 2020
@Adamantcheese
Copy link
Owner

I know the cause issue and will fix it and release an update shortly.

@ghost
Copy link
Author

ghost commented Jun 27, 2020

Nice job figuring that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant