Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTORING] Get rid of volley #237

Closed
K1rakishou opened this issue Jul 26, 2019 · 0 comments
Closed

[REFACTORING] Get rid of volley #237

K1rakishou opened this issue Jul 26, 2019 · 0 comments
Assignees
@Adamantcheese
Labels
enhancement New feature or request

Comments

@K1rakishou
Copy link

We are already using okhttp and the version of volley that we are using is really old since it's not even a library but just the source code. Most of the commits are from the 2014. It's going to be a pain in the ass since this shit is being used in lots of places but it needs to be done.
@K1rakishou K1rakishou added the enhancement New feature or request label Jul 26, 2019
@K1rakishou K1rakishou self-assigned this Jul 26, 2019
@Adamantcheese Adamantcheese mentioned this issue Mar 5, 2020
Closed
Adamantcheese added a commit that referenced this issue May 29, 2020
@Adamantcheese
Move SiteIcon to use OkHttp (partial #237), improvements to how the s…
357c54e 
…ite selector's add dialog works. Required moving of name/icon declarations into the constructor for efficiency; App will crash if these declarations are not in the constructor, however there are plenty of comments to say what to do if this does occur.
@Adamantcheese Adamantcheese mentioned this issue May 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adamantcheese Adamantcheese

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Adamantcheese @K1rakishou