Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dikla Rikovitch Octos #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

diklaaharoni
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I needed to add title and to move the link
Why is it important to consider and use semantic HTML? to make easier to others who looking at my code to understand it
How did you decide to structure your CSS? I wanted to use the same style for all pages this is why i created one css file
What was the most challenging piece of this assignment? to make hover to switch between two images
Describe one area that you gained more clarity on when completing this assignment all
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Your commit messages are descriptive, but I would like to see much more frequent commits.
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main some - instead of <div class="content">, you should use <main> to wrap content that's not in the header or footer.
Appropriately using semantic tags: section, article, etc. some - there are lots of <div>s where something more semantic might be available
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes - if you continue to grow this site, it would probably be wise to break your CSS out into multiple files: main.css, which contains the styles applied to every page (like the header and nav), and a stylesheet for each individual page containing specific styles for that page.
Overall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants