Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#564: Migration fix for program id missing #541

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

sharmarishabh1
Copy link
Collaborator

Pull Request

Description:

Adding a migration to fix the program Id missing in the orders table.

Related Issue(s):

Changes Made:

Added:

  • Added a new migration that runs and checks if program id exists, if not - adds it to the table.

Fixed:

  • fixed the rollback method by adding a proper check to prevent rollback failures.

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

@sharmarishabh1 sharmarishabh1 changed the base branch from master to release/4.0.4 December 16, 2024 08:49
@bhupeshappfoster bhupeshappfoster merged commit a075d08 into release/4.0.4 Dec 17, 2024
@bhupeshappfoster bhupeshappfoster deleted the 564/upsert-program-id-migration branch December 17, 2024 10:56
@bhupeshappfoster bhupeshappfoster mentioned this pull request Dec 17, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants