Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: existing order re-indexing to migration #517

Merged

Conversation

bhupeshappfoster
Copy link
Collaborator

Pull Request

Description:

Fixed the indexing issue causing no result when searching for an order from order listing page for old orders.

Related Issue(s):

Changes Made:

[List the changes made in this pull request to address the issue or implement the feature.]

Added:

  • Logic to re index existing orders within the remove commerce draft migration.

Changed:

  • Removed index flag that prevent indexing when saving orders.

Deprecated:

Removed:

Fixed:

Security:

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
[Include any relevant screenshots to visually demonstrate the changes.]

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@MerrittBoydston
Copy link
Collaborator

🆕 Updates

@bhupeshappfoster
Copy link
Collaborator Author

🆕 Updates

* Just to check @bhupeshappfoster this will resolve 542's search issue, correct?

Yes

@bhupeshappfoster bhupeshappfoster merged commit 49c5885 into release/4.0.0-beta.2 Sep 6, 2024
@bhupeshappfoster bhupeshappfoster deleted the BP/542/order-search-not-working branch September 6, 2024 07:04
bhupeshappfoster added a commit that referenced this pull request Sep 11, 2024
* added: existing order re-indexing to migration (#517)

* fixed: error applying new fields drafts (#520)

* release beta 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants