Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for already merged file from reverting back via callback #487

Conversation

bhupeshappfoster
Copy link
Collaborator

@bhupeshappfoster bhupeshappfoster commented Jan 17, 2024

Pull Request

Description:

Fixed file status reverting back to ready for review when its applied and we receive an order callback.

Related Issue(s):

Changes Made:

[List the changes made in this pull request to address the issue or implement the feature.]

Added:

  • A check before processing a file when receiving an order/file callback.

Changed:

Deprecated:

Removed:

Fixed:

Security:

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
[Include any relevant screenshots to visually demonstrate the changes.]

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@bhupeshappfoster
Copy link
Collaborator Author

I see a bug in this one we need to allow getting quote and needs approval status too when processing files. Will be addressed soon.

@MerrittBoydston
Copy link
Collaborator

Hi @sidedwards and @shnsumit can you please review this PR when you have a moment? Thank you

@bhupeshappfoster bhupeshappfoster merged commit 87b0a6c into release/3.3.4 Jan 20, 2024
@bhupeshappfoster bhupeshappfoster deleted the BP/520/File-status-reverting-back-to-ready-for-review branch January 29, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants