Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: max row size migration error #484

Merged

Conversation

bhupeshappfoster
Copy link
Collaborator

@bhupeshappfoster bhupeshappfoster commented Dec 14, 2023

Pull Request

Description:

Fixed an issue by reducing column size, where create orders table migration was giving max row size error due to innodb_strict_mode.

Related Issue(s):

Changes Made:

[List the changes made in this pull request to address the issue or implement the feature.]

Added:

  • A migration to reduce tags column size in translations_orders table.

Changed:

  • Tags column size in install.php migration file.

Deprecated:

Removed:

Fixed:

Security:

Testing:

  • Performed the migration run and found it doing what is expected.

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
image

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@bhupeshappfoster bhupeshappfoster merged commit b00f6a3 into release/3.3.3 Dec 14, 2023
@bhupeshappfoster bhupeshappfoster deleted the bug/432/migration-error-installing-plugin branch January 17, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants