Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: an issue where uploaded assets saving to temp directory only #477

Conversation

bhupeshappfoster
Copy link
Collaborator

Pull Request

Description:

As we made a fix to error that arise after craft 4.5.0 update in which uploading delivery files was showing error, so we used crafts temp location for it due to which all asset uploads were sent to temp directory irrespective of what volume we select from plugins settings page. Now here we corrected the issue to use the volume if its not 0 and use temp location otherwise.

Related Issue(s):

[Cite any related issues or feature requests, using the GitHub issue link.]

Changes Made:

[List the changes made in this pull request to address the issue or implement the feature.]

Added:

Changed:

Deprecated:

Removed:

Fixed:

Security:

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
[Include any relevant screenshots to visually demonstrate the changes.]

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@bhupeshappfoster bhupeshappfoster merged commit af650e1 into release/3.3.1 Sep 28, 2023
@bhupeshappfoster bhupeshappfoster mentioned this pull request Oct 5, 2023
12 tasks
@bhupeshappfoster bhupeshappfoster deleted the bug/using-custom-volume-if-any-selected-to-upload-assets branch October 5, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants