Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: error shown in dev mode when a new update is available #464

Merged

Conversation

bhupeshappfoster
Copy link
Collaborator

@bhupeshappfoster bhupeshappfoster commented Sep 6, 2023

Pull Request

Description:

A twig error was shown when the dashboard is opened with craft running in dev mode and a new update of plugin is available.

Related Issue(s):

Changes Made:

The update variable obtained as a response from craft update api used to be an object as the old code tries to check a key releases and now it's a boolean value so removed that check to prevent error.

Added:

Changed:

Deprecated:

Removed:

  • The updates.release from logic as updates now is a boolean value.

Fixed:

Security:

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

  • Test to check we don't see an error page when an update is available and the dev mode is enabled for craft setup.

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
image

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@bhupeshappfoster bhupeshappfoster changed the base branch from release/3.2.11 to release/3.3.0 September 18, 2023 07:12
@bhupeshappfoster bhupeshappfoster merged commit b5a764f into release/3.3.0 Sep 18, 2023
@bhupeshappfoster bhupeshappfoster deleted the bug/461/twig-error-when-an-update-is-available branch September 26, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants