Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.2.5 #444

Merged
merged 6 commits into from
May 29, 2023
Merged

Release/2.2.5 #444

merged 6 commits into from
May 29, 2023

Conversation

bhupeshappfoster
Copy link
Collaborator

@bhupeshappfoster bhupeshappfoster commented May 23, 2023

Pull Request

Description:

Plugin license was chowing as free trial even if user adds a paid license.

Related Issue(s):

[#437] Paid version still shows Free Trial
[#439 ] Asset translation issue

Changes Made:

Changed:

  • craft.app.plugins.getPluginLicenseKeyStatus() with craft.app.plugins.getPluginInfo() to check license status.

Removed:

  • Unused code from About template.

Fixed:

  • An issue where asset title was included in translation source file regardless of if the field is translatable or not.

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

  • Testing complete and found no issue impacting the performance.

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
image

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@bhupeshappfoster bhupeshappfoster merged commit 325e9b8 into craft3 May 29, 2023
@bhupeshappfoster bhupeshappfoster deleted the release/2.2.5 branch May 29, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant