Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release notification on dashboard #175

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

shnsumit
Copy link
Collaborator

@shnsumit shnsumit commented Jun 8, 2021

@shnsumit shnsumit requested a review from sidedwards June 8, 2021 23:04
Copy link
Collaborator

@sidedwards sidedwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shnsumit please see below comments. Also, what is the best way to test this feature? Should I just update the template condition to {% if not updates %}?

src/templates/_index.twig Show resolved Hide resolved
src/assetbundles/src/img/right-arrow.svg Outdated Show resolved Hide resolved
@shnsumit
Copy link
Collaborator Author

shnsumit commented Jun 9, 2021

@shnsumit please see below comments. Also, what is the best way to test this feature? Should I just update the template condition to {% if not updates %}?

Yes, you can do that to show the popup.
One another approach can be like you can change the plugin handle name to any other plugin for that its already showing update. In my case its showing update for Neo plugin so I have replaced 'translations' handle to "neo" and its checking the plugin update in real for another plugin.

$variables['updates'] = $this->checkForUpdate('neo');

image

image

Copy link
Collaborator

@sidedwards sidedwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shnsumit please take a look at my comments below.

src/assetbundles/src/img/right-arrow.svg Outdated Show resolved Hide resolved
src/templates/_index.twig Outdated Show resolved Hide resolved
@shnsumit
Copy link
Collaborator Author

@sidedwards Please help me to review the latest commit.

Copy link
Collaborator

@sidedwards sidedwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔬 QA review

  1. Review passed ✅

@sidedwards sidedwards merged commit 79edd99 into release/1.10.5 Jun 10, 2021
@sidedwards sidedwards deleted the feature/new-release-notification branch June 11, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants