-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release notification on dashboard #175
Conversation
shnsumit
commented
Jun 8, 2021
•
edited by sidedwards
Loading
edited by sidedwards
- https://github.com/AcclaroInc/pm-craft-translations/issues/282
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shnsumit please see below comments. Also, what is the best way to test this feature? Should I just update the template condition to {% if not updates %}
?
Yes, you can do that to show the popup. $variables['updates'] = $this->checkForUpdate('neo'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shnsumit please take a look at my comments below.
@sidedwards Please help me to review the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔬 QA review
- Review passed ✅