[WIP] Add support for Moonriver #95

crystalin · 2022-12-17T21:50:24Z

Status: Working, missing better fix for Randomness pallet VRF

It adds:

Inherent => Nimbus - Author Inherent
Inherent => Pallet Randomness - Babe Randomness Result
Consensus => nmbs pre-digest
Config => Moonriver, Moonbeam, Moonbase Alpha

Broken:

The Randomness verification is not passing (temp solution, delete NotFirstBlock at each block)

crystalin · 2022-12-18T09:42:57Z

@xlc is there an easy way to troubleshoot the block produced, including changes in the storage (maybe debug logs level ?)?

xlc · 2022-12-18T10:02:12Z

chopsticks/package.json

Line 25 in 4386ee5

    
           "dev": "LOG_LEVEL=trace ts-node-dev --transpile-only --inspect --notify=false src/index.ts -- dev --config=configs/dev.yml",

with trace level logging you will see storage changes

chopsticks/src/blockchain/txpool.ts

Line 130 in 4386ee5

logger.trace(resp.storageDiff, 'Applied inherent')

configs/moonriver.yml

crystalin · 2022-12-18T13:17:42Z

Currently; it is possible to create 1 block with extrinsic (transfer) but fails for the following block:

[14:15:22.124] ERROR (rpc-author/6439): ExtrinsicFailed
    error: {
      "code": 1,
      "message": "Extrinsic is invalid: {\"invalid\":{\"badProof\":null}}"
    }

ermalkaleci · 2022-12-19T12:51:45Z

@crystalin I was able to produce new blocks for moonriver and did 2 trasfers but I had to delete randomness.notfirstblock before and after block creation to bypass randomness validation.

Add this before this.#chain.newTempBlock(head, header)

head.pushStorageLayer().set(compactHex(meta.query.randomness.notFirstBlock()), StorageValueKind.Deleted)

Add this after BlockBuilder_finalize_block

if (meta.query.randomness?.notFirstBlock) {
      newBlock.pushStorageLayer().set(compactHex(meta.query.randomness.notFirstBlock()), StorageValueKind.Deleted)
    }

ermalkaleci · 2022-12-19T12:54:17Z

@crystalin also I used your config.yml but without block number

crystalin · 2022-12-19T14:07:58Z

@ermalkaleci thanks, it seems to work for me too. Howerver it only support Runtime 2000 (which wasn't the one used initially but Moonriver has been upgraded since).

Concerning the hard coded changes, do you have an idea how to include them better ?

ermalkaleci · 2022-12-19T14:24:52Z

@ermalkaleci thanks, it seems to work for me too. Howerver it only support Runtime 2000 (which wasn't the one used initially but Moonriver has been upgraded since).

Concerning the hard coded changes, do you have an idea how to include them better ?

because smoldot job is to sync with current state of chains, it doesn't support old tx version.
we also added support for genesis config meaning you can start the chain with genesis without an endpoint but it will not work if genesis is too old, smoldot will p will throw invalid transaction. See configs/mandala-genesis.yml

regarding hard coded changes I am not sure, maybe it can be inside consensus closure. I didn't spend much time, just tried to cheat, not sure if we can modify digest logs to make it valid

src/blockchain/txpool.ts

crystalin · 2022-12-19T14:57:26Z

@ermalkaleci Thank you.

I also tested a runtime upgrade and it worked, but it can't produce blocks anymore after that (same issue I believe):

    prevHash: "0x3e6f92d000000000000000000000000000000000000000000000000000000000"
[15:53:23.132] ERROR (rpc-author/25217): ExtrinsicFailed
    error: {
      "code": 1,
      "message": "Extrinsic is invalid: {\"invalid\":{\"badProof\":null}}"
    }
[15:56:16.554] INFO (txpool/25217): Building block
    hash: "0x87cbcbcdc5ab007599e148ad4e0f02b24072fd096285b8266ab5bc0cbad0587d"
    number: 3222725
    extrinsicsCount: 1
    tempHash: "0x521197e000000000000000000000000000000000000000000000000000000000"
    timeValue: 1671461506894
    expectedSlot: 835730753447
createInherents kickOffAuthorshipValidation 3222726
createInherents SetBabeRandomness 3222726
[15:56:18.951] WARN (txpool/25217): Failed to apply inherents {} Error: Error while executing Wasm VM: Trap: Unreachable
"panicked at 'Bad input data provided to apply_extrinsic: Codec error', /home/crystalin/projects/moonbeam/runtime/moonriver/src/lib.rs:1298:1"
/home/crystalin/projects/chopsticks/src/blockchain/txpool.ts:144
        throw new ResponseError(1, 'Failed to apply inherents')
              ^
ResponseError: Failed to apply inherents
    at TxPool.#buildBlock (/home/crystalin/projects/chopsticks/src/blockchain/txpool.ts:144:15)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async TxPool.buildBlock (/home/crystalin/projects/chopsticks/src/blockchain/txpool.ts:64:5) {
  code: 1
}

ermalkaleci · 2022-12-19T15:00:34Z

@crystalin can you try refreshing polkadotjs app after the upgrade? upgrade subscription isn't implemented yet

crystalin · 2022-12-19T15:11:02Z

I did, as otherwise I can't send transaction. It showed the new version and supported to send the transaction but chopsticks failed.
(I tried twice)

crystalin · 2022-12-19T15:16:36Z

Here is a RT2100 for Moonriver. You need to "enactAuthorizedUpgrade" (I added the authorization in the genesis of moonriver.yml): https://drive.google.com/file/d/1vVVR-YosRspnUEIHg9iLmI4nrBBffEXy/view?usp=sharing

ermalkaleci · 2022-12-19T16:32:17Z

@crystalin ok I think I know the reason. We're not updating metadata when upgrade happens. Fixing it

ermalkaleci · 2022-12-19T18:47:35Z

@crystalin fixed

crystalin · 2022-12-19T19:24:42Z

@ermalkaleci I merged master and still get the same issue

ermalkaleci · 2022-12-19T19:26:50Z

@ermalkaleci I merged master and still get the same issue

Did you rebuilt wasm?

crystalin · 2022-12-19T20:36:07Z

Yes I did (otherwise it doesn't even restart)

crystalin · 2022-12-19T21:34:48Z

Ok so I think it might be due to a transaction that stays in the pool during the runtime upgrade. and then fails to be applied at the following block.
I tried to use manual (but api.rpc.engine.createBlock didn't exist it seems) or instant (this one never produces a block event with txs in the pool)

ermalkaleci · 2022-12-19T21:56:12Z

Ok so I think it might be due to a transaction that stays in the pool during the runtime upgrade. and then fails to be applied at the following block.

I tried to use manual (but api.rpc.engine.createBlock didn't exist it seems) or instant (this one never produces a block event with txs in the pool)

You can go to js section and do api.rpc("dev_newBlock")

ermalkaleci · 2022-12-19T21:56:44Z

#91 (comment)

ermalkaleci · 2022-12-19T21:58:24Z

I tested your runtime. Upgrade was successfully but I got the error trying to build new blocks. Is this runtime compatible with smoldot?

crystalin · 2022-12-19T22:13:25Z

You are right, the runtime might have been broken. I didn't really check with commit I built it from.
I took the previous runtime and simply changed the version and it seems to work fine now !!! :)

xlc · 2022-12-19T22:44:09Z

You may want to add tests like this to avoid accidentally breaks the compatibility

https://github.com/AcalaNetwork/chopsticks/blob/master/e2e/relaychain.test.ts

crystalin · 2022-12-20T11:42:08Z

src/blockchain/txpool.ts

@@ -97,6 +112,7 @@ export class TxPool {
      },
    })

+    head.pushStorageLayer().set(compactHex(meta.query.randomness.notFirstBlock()), StorageValueKind.Deleted)


@xlc not sure what we could do here. Ideally, the signature should be mocked too but quickly looking at the randomness pallet I don't see much how this could be done.
A temporary solution is to remove the NotFirstBlock but it needs to be pallet specific and also break support for randomness.
Any idea ?

how does the randomness pallet verify the VRF? if that's using host function than we can mock it. otherwise I can see few options:

modify randomness pallet to make it mock friendly. e.g. if a particular storage exists or not exists, switch to mock mode

refactor chopsticks to support plugins so we can better manage pallet specific code

So it checks the NotFirstBlock there https://github.com/PureStake/moonbeam/blob/master/pallets/randomness/src/lib.rs#L294
And the verification is (few lines under) pointing to https://github.com/PureStake/moonbeam/blob/master/pallets/randomness/src/vrf.rs#L32

crystalin · 2022-12-20T12:45:19Z

@ermalkaleci latest master seems broken (I tried to update submodule run yarn and ....)

Error: Cannot find module '@chopsticks/logger'
Require stack:
- /home/crystalin/projects/chopsticks/src/blockchain/storage-layer.ts
- /home/crystalin/projects/chopsticks/src/blockchain/block.ts
- /home/crystalin/projects/chopsticks/src/blockchain/txpool.ts
- /home/crystalin/projects/chopsticks/src/index.ts
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:985:15)
    at Function.Module._resolveFilename.sharedData.moduleResolveFilenameHook.installedValue [as _resolveFilename] (/home/crystalin/projects/chopsticks/node_modules/@cspotcode/source-map-support/source-map-support.js:811:30)
    at Function.Module._load (node:internal/modules/cjs/loader:833:27)
    at Module.require (node:internal/modules/cjs/loader:1057:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/home/crystalin/projects/chopsticks/src/blockchain/storage-layer.ts:5:1)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Module.m._compile (/home/crystalin/projects/chopsticks/node_modules/ts-node/src/index.ts:1618:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Object.require.extensions.<computed> [as .ts] (/home/crystalin/projects/chopsticks/node_modules/ts-node/src/index.ts:1621:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/crystalin/projects/chopsticks/src/blockchain/storage-layer.ts',
    '/home/crystalin/projects/chopsticks/src/blockchain/block.ts',
    '/home/crystalin/projects/chopsticks/src/blockchain/txpool.ts',
    '/home/crystalin/projects/chopsticks/src/index.ts'
  ]
}

ermalkaleci · 2022-12-20T13:06:36Z

@ermalkaleci latest master seems broken (I tried to update submodule run yarn and ....)

Error: Cannot find module '@chopsticks/logger'
Require stack:
- /home/crystalin/projects/chopsticks/src/blockchain/storage-layer.ts
- /home/crystalin/projects/chopsticks/src/blockchain/block.ts
- /home/crystalin/projects/chopsticks/src/blockchain/txpool.ts
- /home/crystalin/projects/chopsticks/src/index.ts
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:985:15)
    at Function.Module._resolveFilename.sharedData.moduleResolveFilenameHook.installedValue [as _resolveFilename] (/home/crystalin/projects/chopsticks/node_modules/@cspotcode/source-map-support/source-map-support.js:811:30)
    at Function.Module._load (node:internal/modules/cjs/loader:833:27)
    at Module.require (node:internal/modules/cjs/loader:1057:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/home/crystalin/projects/chopsticks/src/blockchain/storage-layer.ts:5:1)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Module.m._compile (/home/crystalin/projects/chopsticks/node_modules/ts-node/src/index.ts:1618:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Object.require.extensions.<computed> [as .ts] (/home/crystalin/projects/chopsticks/node_modules/ts-node/src/index.ts:1621:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/crystalin/projects/chopsticks/src/blockchain/storage-layer.ts',
    '/home/crystalin/projects/chopsticks/src/blockchain/block.ts',
    '/home/crystalin/projects/chopsticks/src/blockchain/txpool.ts',
    '/home/crystalin/projects/chopsticks/src/index.ts'
  ]
}

yeah forgot ts-node registrer-ts-paths. fixing

src/blockchain/txpool.ts

Co-authored-by: Ermal Kaleci <[email protected]>

crystalin · 2022-12-28T15:25:31Z

@ermalkaleci: Done, it seems to work well with current code

xlc · 2023-01-10T22:55:28Z

Is this ready for merge @crystalin ?

crystalin · 2023-01-11T08:58:06Z

@xlc it is yes

crystalin · 2023-01-11T11:27:05Z

I merged master but is now failing the test :(

Draft support for Moonriver

80ab0b7

Merge branch 'master' into crystalin-moonriver

b028dbe

ermalkaleci reviewed Dec 18, 2022

View reviewed changes

configs/moonriver.yml Outdated Show resolved Hide resolved

crystalin added 3 commits December 18, 2022 14:00

Better storage modification for Moonriver

ed87ac2

Merge branch 'master' into crystalin-moonriver

d0887e4

temp fix for default storage issue

d9775a1

crystalin added 2 commits December 19, 2022 15:00

Merge branch 'master' into crystalin-moonriver

cb8349c

removes notFirstBlock

3db2d02

ermalkaleci reviewed Dec 19, 2022

View reviewed changes

src/blockchain/txpool.ts Outdated Show resolved Hide resolved

remove unnecessary randomness storage modification

8c276a7

Adds RT2100 Dev image in authorized upgrade

72fc9b3

Merge branch 'master' into crystalin-moonriver

105c12e

Better support for nmbs engine

c546ccf

crystalin commented Dec 20, 2022

View reviewed changes

crystalin added 3 commits December 20, 2022 13:41

Merge branch 'master' into crystalin-moonriver

cad8131

fix missing import

2045c72

lint

e80a133

crystalin added 2 commits December 20, 2022 20:51

Merge branch 'master' into crystalin-moonriver

33d6f98

Merge branch 'master' into crystalin-moonriver

1c7bce6

ermalkaleci reviewed Dec 28, 2022

View reviewed changes

src/blockchain/txpool.ts Outdated Show resolved Hide resolved

Alan Sapede and others added 3 commits December 28, 2022 15:09

Update src/blockchain/txpool.ts

da111ca

Co-authored-by: Ermal Kaleci <[email protected]>

Merge branch 'master' into crystalin-moonriver

83e760b

Fix inherents

c86d47a

crystalin added 3 commits December 29, 2022 08:49

Removes extra storage push

0d897fe

Better file split

4d77abf

fix e2e imports

ec0772f

Merge branch 'master' into crystalin-moonriver

c917476

ermalkaleci approved these changes Jan 11, 2023

View reviewed changes

xlc merged commit a279b9f into AcalaNetwork:master Jan 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add support for Moonriver #95

[WIP] Add support for Moonriver #95

crystalin commented Dec 17, 2022 •

edited

Loading

crystalin commented Dec 18, 2022

xlc commented Dec 18, 2022

crystalin commented Dec 18, 2022

ermalkaleci commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022 •

edited

Loading

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

xlc commented Dec 19, 2022

crystalin Dec 20, 2022

xlc Dec 20, 2022

crystalin Dec 21, 2022

crystalin commented Dec 20, 2022

ermalkaleci commented Dec 20, 2022

crystalin commented Dec 28, 2022

xlc commented Jan 10, 2023

crystalin commented Jan 11, 2023

crystalin commented Jan 11, 2023

[WIP] Add support for Moonriver #95

[WIP] Add support for Moonriver #95

Conversation

crystalin commented Dec 17, 2022 • edited Loading

crystalin commented Dec 18, 2022

xlc commented Dec 18, 2022

crystalin commented Dec 18, 2022

ermalkaleci commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022 • edited Loading

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

crystalin commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

ermalkaleci commented Dec 19, 2022

crystalin commented Dec 19, 2022

xlc commented Dec 19, 2022

crystalin Dec 20, 2022

Choose a reason for hiding this comment

xlc Dec 20, 2022

Choose a reason for hiding this comment

crystalin Dec 21, 2022

Choose a reason for hiding this comment

crystalin commented Dec 20, 2022

ermalkaleci commented Dec 20, 2022

crystalin commented Dec 28, 2022

xlc commented Jan 10, 2023

crystalin commented Jan 11, 2023

crystalin commented Jan 11, 2023

crystalin commented Dec 17, 2022 •

edited

Loading

ermalkaleci commented Dec 19, 2022 •

edited

Loading