feat(chainHead_v1): fake closestDescendantMerkleValue #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add some comments explaining the difference behaviour in Chopsticks vs spec? |
xlc
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #870
This gives support for Polkadot-API's
query.watchEntries(), which subscribes to the storage usingclosestDescendantMerkleValueto detect changes.As discussed in #870, chopsticks doesn't work with the merkle tree directly, but with storage diffs.
As polkadot-api doesn't really need the correct hash, but just that the value returned is different when any storage value under that branch changes, this implementation fakes the merkleValue to be based on a counter of how many changes were detected for that branch.
I have added a test with the top-level client of polkadot-api (now that it doesn't require codegen/descriptors to run) and it seems to be working as expected.