Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update precompile gas_limit #2007

Merged
merged 3 commits into from
Mar 31, 2022
Merged

update precompile gas_limit #2007

merged 3 commits into from
Mar 31, 2022

Conversation

ermalkaleci
Copy link
Contributor

precompiles consumes 90% of gas_limit in case of revert

@ermalkaleci ermalkaleci requested review from zjb0807 and xlc March 30, 2022 11:38
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #2007 (5569baa) into master (5a8f381) will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2007      +/-   ##
==========================================
+ Coverage   86.09%   86.38%   +0.29%     
==========================================
  Files          99       98       -1     
  Lines       20003    20131     +128     
==========================================
+ Hits        17221    17390     +169     
+ Misses       2782     2741      -41     
Impacted Files Coverage Δ
modules/support/src/mocks.rs 57.89% <0.00%> (-13.08%) ⬇️
modules/auction-manager/src/lib.rs 76.49% <0.00%> (-0.38%) ⬇️
modules/cdp-engine/src/lib.rs 74.76% <0.00%> (-0.20%) ⬇️
modules/support/src/dex.rs 28.57% <0.00%> (ø)
modules/incentives/src/tests.rs 100.00% <0.00%> (ø)
modules/cdp-treasury/src/tests.rs 100.00% <0.00%> (ø)
primitives/src/currency.rs
modules/asset-registry/src/tests.rs 99.65% <0.00%> (+0.03%) ⬆️
modules/cdp-engine/src/tests.rs 100.00% <0.00%> (+0.18%) ⬆️
modules/cdp-treasury/src/lib.rs 85.92% <0.00%> (+0.20%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8f381...5569baa. Read the comment docs.

ermalkaleci and others added 2 commits March 30, 2022 14:00
Copy link
Member

@zjb0807 zjb0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ermalkaleci ermalkaleci merged commit 36eb469 into master Mar 31, 2022
@ermalkaleci ermalkaleci deleted the update_precompile_gas_limit branch March 31, 2022 08:19
syan095 pushed a commit that referenced this pull request Apr 8, 2022
…ts-for-currencies

* origin/master: (362 commits)
  Skip idle_scheduler Calls When Not Producing blocks  (#1721)
  config more homa subaccounts for Karura (#2004)
  rm wt storage (#1984)
  Update construct_runtime's syntax (#2000)
  polkadot v0.9.18 (#1988)
  be srtool compatible (#2021)
  Update README.md (#2022)
  update precompile weights (#2020)
  Mandala supports PricingPegged for taiKSM (#2015)
  remove unneeded param (#2014)
  fix srtool (#2013)
  update precompile gas_limit (#2007)
  fix verify bootnodes script
  Bump minimist from 1.2.5 to 1.2.6 in /ts-tests (#2008)
  Bump (#2005)
  add NativeAssetId to asset registry (#1993)
  connect earning and incentives (#1995)
  Liquidation (#1955)
  Improvement/orml oracle (#1998)
  Mock xcm (#1977)
  ...

# Conflicts:
#	modules/currencies/src/lib.rs
#	predeploy-contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants