Fix unit test warnings on Mac related to openvdb::Index64 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unsigned long long not unsigned long on Mac
|
Funny - I made the exact same changes didn't push them yet :) -K |
swahtz
added a commit
to swahtz/openvdb
that referenced
this pull request
Jan 21, 2025
…ion#75) * Add basic cmake and an example gbenchmark * Modify setup.py to exclude benchmarks directory * gitignore benchmarks build dir * Make CMake work with conda-forge Torch, and make simple benchmark use Torch. * Add working C++11 ABI Torch conda environment * Modularize the cmake. * Whitespace cleanup * empty Signed-off-by: Jonathan Swartz <[email protected]> * Add comment about excluding benchmarks directory * Modularize python, torch and fvdb dependencies, and add better error checking * Empty commit to test signing * Empty commit to test signing * Use `find_library` to find libfvdb.so --------- Signed-off-by: Jonathan Swartz <[email protected]> Co-authored-by: Jonathan Swartz <[email protected]> Co-authored-by: Francis Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac, openvdb::Index64 is uint64_t which is unsigned long long, not unsigned long. This patch fixes the warnings about the mismatching types in the unit tests by using Index64 instead of size_t or 0UL/1UL.