Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NanoVDB with latest changes #2001

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update NanoVDB with latest changes #2001

wants to merge 2 commits into from

Conversation

matthewdcong
Copy link
Contributor

This PR introduces and includes several improvements to NanoVDB.

From @kmuseth :

  • Added support for multiple GPUs to DeviceBuffer
  • Added a UnifiedBuffer class that wraps CUDA unified memory
  • Added CUDA utility functions for device queries
  • Added functions to independently stop and compute the elapsed time for timer classes
  • Fixed ostream specializations being hidden within the nanovdb namespace

From @matthewdcong

  • Added example for multiGPU sparse convolution
  • Replaced CUB's CachingDeviceAllocator with the default asynchronous stream ordered allocator in PointsToGrid for improved performance

swahtz
swahtz reviewed Jan 31, 2025
View reviewed changes
nanovdb/nanovdb/NanoVDB.h
@@ -1228,6 +1243,25 @@ class Mask
{
on ? this->setOnAtomic(n) : this->setOffAtomic(n);
}
/*
template<typename WordT>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓 nitpick (non-blocking): ‏ Should we remove (or uncomment) this code before merging?

Copy link
Contributor Author

@matthewdcong matthewdcong Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as-is for now, can always remove as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swahtz swahtz swahtz left review comments

@kmuseth kmuseth Awaiting requested review from kmuseth kmuseth is a code owner

@apradhana apradhana Awaiting requested review from apradhana apradhana is a code owner

@jmlait jmlait Awaiting requested review from jmlait jmlait is a code owner

@Idclip Idclip Awaiting requested review from Idclip Idclip is a code owner

@danrbailey danrbailey Awaiting requested review from danrbailey danrbailey is a code owner

@richhones richhones Awaiting requested review from richhones richhones is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewdcong @swahtz