Added patch to USD for DTS bug #25
Conversation
Signed-off-by: Aloys Baillet <[email protected]>
Signed-off-by: Aloys Baillet <[email protected]>
There was a problem hiding this comment.
My bash-fu is minimal, could the heredoc expression:
cat <<EOF | patch -p1
be shortened to:
patch -p1 <<EOF
or is there a reason for pushing the text of the patch through cat first?
Also for the change from make -j64 to make -j12, this article has some suggestions on using the output of nproc to set that variable based on the number of cores, which might be more adaptable to a build environment with a different number of available cores?
Signed-off-by: Aloys Baillet <[email protected]>
|
Thanks JF! Sorry took me a while to come back to this one... I think I used to use dynamic CPU number but got burnt by this on circle-ci as the machines had lots of CPUs and not enough memory so using them all would just crash the compiler... That said we seem good now on Azure :-) |
Signed-off-by: Aloys Baillet <[email protected]>
|
Sorry I just realised I forgot to increase the version number for the docker image :-( sorry JF you'll need to re-approve yet again! |
See comments in Autodesk/maya-usd#198
This supersedes #24 as patch was not quite working and Eoin didn't use DCO...