Python3 fixes for the shot_detect example #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ssteinbach
force-pushed
the
shot_detect_python3_fix.py
branch
from
b1760a7 to
a6fc310
Compare
Signed-off-by: ssteinbach <[email protected]>
ssteinbach
force-pushed
the
shot_detect_python3_fix.py
branch
from
a6fc310 to
9ec742a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1374 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 196 196
Lines 19865 19865
Branches 2309 2309
=======================================
Hits 17138 17138
Misses 2161 2161
Partials 566 566
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
reinecke
approved these changes
Aug 18, 2022
MichaelPlug
pushed a commit
to MichaelPlug/OpenTimelineIO
that referenced
this pull request
Aug 5, 2023
…1374) Signed-off-by: ssteinbach <[email protected]> Signed-off-by: Michele Spina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python bytes vs str issue is present in the
shot_detect.pyexample. This should fix that and make it usable again.