Revisited how transitions are handled by the cmx 3600 adapter. #1341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code handling transitions in the cmx 3600 adapter was hard to follow and was introducing problems. These changes
fix these problems and make the code easier to maintain.
ClipHandler
.Clip
source and record points are replaced with the transition values when the line is parsed.in_offset
is now 0 and theout_offset
is the transition duration, matching in the timeline what would be done if the editing was read from another format.Fixes #1328
Fixes #912
Fixes #977
Now the transitions read from an EDL appear at the right time in the timeline, and the timeline has the right overall length.
Associated tests.
These changes are covered by the
test_cmx_3600_adapter
tests. A read/write/read roundtrip test was added to ensure they are compatible with the writer.