Support OTIO_PLUGIN_MANIFEST_PATH being set to an empty string #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the ability to set OTIO_PLUGIN_MANIFEST_PATH to an empty string to indicate no local custom manifest file.
avrata
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 86.10% 86.09% -0.01%
==========================================
Files 196 196
Lines 19647 19665 +18
Branches 2305 2308 +3
==========================================
+ Hits 16917 16931 +14
- Misses 2171 2173 +2
- Partials 559 561 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
andrewmoore-nz
added a commit
to thecargocultnz/OpenTimelineIO
that referenced
this pull request
Apr 5, 2022
* main: Add Python 3.10 to CI (AcademySoftwareFoundation#1256) Fix missing init metadata (AcademySoftwareFoundation#1251) Support OTIO_PLUGIN_MANIFEST_PATH being set to an emptry string (AcademySoftwareFoundation#1253) Add ALE adapter argument `ale_name_column_key` (AcademySoftwareFoundation#1248) AAF Adapter: Mob transcription heuristics (AcademySoftwareFoundation#1249) Bump src/deps/Imath from `bd6f74c` to `bd254da` (AcademySoftwareFoundation#1245) clang notices that constexpr can't be used on a mutating function (AcademySoftwareFoundation#1242)
jminor
pushed a commit
that referenced
this pull request
May 2, 2022
This restores the ability to set OTIO_PLUGIN_MANIFEST_PATH to an empty string to indicate no local custom manifest file. Co-authored-by: Robyn Rindge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the ability to set OTIO_PLUGIN_MANIFEST_PATH to an empty string
to indicate no local custom manifest file.
Link the Issue(s) this Pull Request is related to.
Fixes #1252
Summarize your change.
This changes a truthy check on the env var OTIO_PLUGIN_MANIFEST_PATH to skip any false value and not explicitly
is None. This will allow OTIO_PLUGIN_MANIFEST_PATH='' to be equivalent to that env var not being set.Reference associated tests.
Added a test specifically for this. Also updated all tests in
test_adapter_plugin.pyto always un-set custom env vars or manifests on exceptions due to test failures so as to not pollute subsequent tests.