ci: Remove old MacOS-12 CI test #4464
Conversation
It's an old flavor not well supported by homebrew any longer, so what's happening is that most of the dependency packages we ask to install have to build from source, which means it takes a long long time. Just get rid of it, we have two other Mac test cases -- a newer MacOS 13 Intel one, and a MacOS 14 ARM one. That's enough coverage. Signed-off-by: Larry Gritz <[email protected]>
|
The https://vfxplatform.com/ says we should target macOS 12.0 SDK. We can do that on newer macOS by I think setting in cmake CMAKE_OSX_DEPLOYMENT_TARGET. Do we have that? If not, should we add it to say the MacOS-13 runner as part of this PR? |
I'm not sure I understand what that does, in light of the fact that we don't rely on anything other than the standard C++ library (nothing newer than C++17) and the other open source dependencies we install ourselves. We're not using any native MacOS APIs, so I'm not sure what there is to nail down specifically to OSX 12.x. I also have an alternate design that works fine, which is to KEEP this MacOS-12 test, but instruct it not to build OpenCV or Qt. So that means that only for MacOS-12, we wouldn't be building in support for the OpenCV interop or osltoy -- neither of which is actually tested by the automated testsuite anyway. If you think that's a better approach, I can replace the present PR by that version. |
|
Alternate approach: #4465 |
|
It's for more than just macos API. Take this random link I found https://stackoverflow.com/a/19819591 which says it's used for selecting the C++ STL implementation. Unlike linux where we need to build on older distros so we build against an old enough glibc so the binary works for all users, on macs you can build on the latest macos and instead use this flag to tell the compiler/linker what to target. |
|
OK, I'll close this PR and keep building specifically on MacOS-12. |
It's an old flavor not well supported by homebrew any longer, so what's happening is that some of the dependency packages we ask to install have to build from source, which means it takes a long long time. Just get rid of it, we have two other Mac test cases -- a newer MacOS 13 Intel one, and a MacOS 14 ARM one. That's enough coverage.