Use undefined behavior sanitizer (ubsan) as part of CI #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to address and leak sanitizers, also turn on the undefined behavior sanitizer in our CI run. We can do it in the same job as asan/lsan. Some things that come along for the ride, including fixes for things that ubsan uncovered: * src/build-scripts/ubsan-suppressions.txt can hold suppression list (though we don't have any now, it just sets up the space for it for future needs). * Split the "targa" test so that the parts that directly need the OIIO python module (which are all related to thumbnails) are now in "targa-thumbnails" test. That has to be disabled for the sanitizers, since we can't arrange for python to b linked to the sanitizer libraries. * Found vint4::store has a potentially unaligned integer store. * Found Strutil::concat is not necessarily safe if either of the strings are empty.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 7, 2022
…reFoundation#3565) In addition to address and leak sanitizers, also turn on the undefined behavior sanitizer in our CI run. We can do it in the same job as asan/lsan. Some things that come along for the ride, including fixes for things that ubsan uncovered: * src/build-scripts/ubsan-suppressions.txt can hold suppression list (though we don't have any now, it just sets up the space for it for future needs). * Split the "targa" test so that the parts that directly need the OIIO python module (which are all related to thumbnails) are now in "targa-thumbnails" test. That has to be disabled for the sanitizers, since we can't arrange for python to b linked to the sanitizer libraries. * Found vint4::store has a potentially unaligned integer store. * Found Strutil::concat is not necessarily safe if either of the strings are empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to address and leak sanitizers, also turn on the undefined behavior sanitizer in our CI run. We can do it in the same job as asan/lsan.
Some things that come along for the ride, including fixes for things that ubsan uncovered:
src/build-scripts/ubsan-suppressions.txt can hold suppression list (though we don't have any now, it just sets up the space for it for future needs).
Split the "targa" test so that the parts that directly need the OIIO python module (which are all related to thumbnails) are now in "targa-thumbnails" test. That has to be disabled for the sanitizers, since we can't arrange for python to b linked to the sanitizer libraries.
Found vint4::store has a potentially unaligned integer store.
Found Strutil::concat is not necessarily safe if either of the strings are empty.