PNG fixes #3544
Merged
PNG fixes #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Minor png refactoring to fix some memory leaks for broken png files. * Remove unused string variable from read_info() and simplify the surrounding "if" * Split png test into png and png-damaged, because I just can't seem to squash some very minor memory leaks for broken png files, I think it's not worth worrying about and I'll just exclude the broken case from testing for the address sanitizer.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 14, 2022
* Minor png refactoring to fix some memory leaks for broken png files. * Remove unused string variable from read_info() and simplify the surrounding "if" * Split png test into png and png-damaged, because I just can't seem to squash some very minor memory leaks for broken png files, I think it's not worth worrying about and I'll just exclude the broken case from testing for the address sanitizer.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 21, 2022
* Minor png refactoring to fix some memory leaks for broken png files. * Remove unused string variable from read_info() and simplify the surrounding "if" * Split png test into png and png-damaged, because I just can't seem to squash some very minor memory leaks for broken png files, I think it's not worth worrying about and I'll just exclude the broken case from testing for the address sanitizer.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 4, 2022
* Minor png refactoring to fix some memory leaks for broken png files. * Remove unused string variable from read_info() and simplify the surrounding "if" * Split png test into png and png-damaged, because I just can't seem to squash some very minor memory leaks for broken png files, I think it's not worth worrying about and I'll just exclude the broken case from testing for the address sanitizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor png refactoring to fix some memory leaks for broken png files.
Remove unused string variable from read_info() and simplify the
surrounding "if"
Split png test into png and png-damaged, because I just can't seem
to squash some very minor memory leaks for broken png files, I think
it's not worth worrying about and I'll just exclude the broken case
from testing for the address sanitizer.