Work around find_package() failure for boost versions with cmake output #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e output The FindBoost.cmake interface is broken if it uses boost's installed cmake output (e.g. boost 1.70.0, cmake <= 3.14) at least in the case that boost was installed to a non-standard prefix. Specifically it fails to set variables as indicated in FindBoost.cmake documentation. So until that's fixed force FindBoost.cmake to use the original path which is consistent with its docs.
lgritz
approved these changes
Jul 16, 2019
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 16, 2019
…e output (AcademySoftwareFoundation#2293) The FindBoost.cmake interface is broken if it uses boost's installed cmake output (e.g. boost 1.70.0, cmake <= 3.14) at least in the case that boost was installed to a non-standard prefix. Specifically it fails to set variables as indicated in FindBoost.cmake documentation. So until that's fixed force FindBoost.cmake to use the original path which is consistent with its docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FindBoost.cmake interface is broken if it uses boost's installed cmake
output (e.g. boost 1.70.0, cmake <= 3.14) at least in the case that boost
was installed to a non-standard prefix. Specifically it fails to set
variables as indicated in FindBoost.cmake documentation. So until that's
fixed force FindBoost.cmake to use the original path which is consistent
with its docs.
Description
Tests
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).