ColorConfig additions #2248
Merged
ColorConfig additions #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
force-pushed
the
lg-colorconfig
branch
2 times, most recently
from
5ea8633 to
47413b5
Compare
Background: ColorConfig is our wrapper around some OpenColorIO functionality, so that apps whose only need for OCIO is for the sake of OIIO color conversion functions, they can go though this thin interface instead of directly needing to navigate the more complicated APIs of OCIO. It also allows us to abstract whether OCIO is actually available, if it's not it understands just a couple hard-coded color transformations. * Add getColoSpaceFamilyByName, which was some OCIO functionality we did not expose before. * Add methods that return a vector of strings containing the list of all color spaces, looks, displays, or views for a display. * Expose all this to Python. And add a simple unit test. * Make sure one Travis test disables OCIO support, so we know what breaks under those circumstances.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 4, 2019
Background: ColorConfig is our wrapper around some OpenColorIO functionality, so that apps whose only need for OCIO is for the sake of OIIO color conversion functions, they can go though this thin interface instead of directly needing to navigate the more complicated APIs of OCIO. It also allows us to abstract whether OCIO is actually available, if it's not it understands just a couple hard-coded color transformations. * Add getColoSpaceFamilyByName, which was some OCIO functionality we did not expose before. * Add methods that return a vector of strings containing the list of all color spaces, looks, displays, or views for a display. * Expose all this to Python. And add a simple unit test. * Make sure one Travis test disables OCIO support, so we know what breaks under those circumstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: ColorConfig is our wrapper around some OpenColorIO
functionality, so that apps whose only need for OCIO is for the sake
of OIIO color conversion functions, they can go though this thin
interface instead of directly needing to navigate the more complicated
APIs of OCIO. It also allows us to abstract whether OCIO is actually
available, if it's not it understands just a couple hard-coded color
transformations.
Add getColoSpaceFamilyByName, which was some OCIO functionality we
did not expose before.
Add methods that return a vector of strings containing the list of
all color spaces, looks, displays, or views for a display.
Expose all this to Python. And add a simple unit test.
Make sure one Travis test disables OCIO support, so we know what
breaks under those circumstances.