HEIF support #2160
Merged
HEIF support #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take me off your email list
Sent from Margie's iPhone
… On Jan 24, 2019, at 1:32 AM, Larry Gritz ***@***.***> wrote:
HEIF is a container for HEIC-compressed images. HEIC is the still image
sibling to HEVC video compression. Roughly speaking, it produces lossy
compressed images about half the file size of JPEGs but with higher
visual quality.
At the moment, it's hard to find software that will reliably read
heic/heif, except for recent cuts of software within the Apple ecosystem
(the only ones I've encountered so far are iPhone camera images). But
that will surely change, since it's a superior format to JPEG in many
ways.
This is the first stab at supporting heif/heic images using the open
source libheif. I'm fairly confident in the reading, including exif
metadata, of RGB and RGBA images, including files with multiple images.
I've not yet figured out depth images.
This can also write images (but only single images per file, RGB or
RGBA), and although the exif metadata I write can be read again by
OIIO's heif reader, Apple's Preview.app does not recognize the metadata
for some reason. I don't know why, maybe I'll return to that later.
I also want to fix later the limitation of not being able to output
multi-image heif files.
Along the way, I converted decode_xmp() utility to be based on
string_view, and also changed encode_exif() to take an explicit
'endianreq' parameter so it's possible to request a specific
endianness. (Apple's Preview.app, which is the main way I was able to
test whether I'm writing them correctly, requires that the exif be
written as big endian, or it won't recognize the file as proper heic at
all. So that required some extensive changes in my exif blob code.)
The latest release of libheif, 1.3, doesn't fully support color
profiles. The in-progress libheif master (future 1.4) does, so I'll add
support when that is released. For now, it always looks like sRGB, and
that seems to be the common case, but it can be incorrect.
Currently, we only will read and write uint8 pixel data. The libheif
authors are working on full support for HDR/extended range, but that's
not even merged into its master yet. I'll add support in the OIIO heif
reader as that gets merged into libheif releases.
You can view, comment on, or merge this pull request online at:
#2160
Commit Summary
HEIF support
File Changes
M CHANGES.md (3)
M CMakeLists.txt (5)
M INSTALL.md (2)
M README.md (4)
M site/spi/Makefile-bits-arnold (3)
M site/spi/Makefile-bits-spcomp2 (3)
M src/build-scripts/install_homebrew_deps.bash (1)
M src/cmake/externalpackages.cmake (10)
A src/cmake/modules/FindLibheif.cmake (56)
M src/doc/builtinplugins.tex (30)
M src/doc/oiiointro.tex (3)
A src/heif.imageio/CMakeLists.txt (8)
A src/heif.imageio/heifinput.cpp (290)
A src/heif.imageio/heifoutput.cpp (237)
M src/include/OpenImageIO/tiffutils.h (15)
M src/libOpenImageIO/exif.cpp (166)
M src/libOpenImageIO/exif.h (3)
M src/libOpenImageIO/imageioplugin.cpp (4)
M src/libOpenImageIO/xmp.cpp (36)
A testsuite/heif/ref/IMG_7702_small.heic (0)
A testsuite/heif/ref/out.txt (40)
A testsuite/heif/run.py (6)
Patch Links:
https://github.com/OpenImageIO/oiio/pull/2160.patch
https://github.com/OpenImageIO/oiio/pull/2160.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@jaggedmgroup This is not an email list. If you're getting notifications about pull requests, it's because you are "watching" the GitHub repository for this project. It's not something we can fix for you, you'll have to click the "unwatch" button on your end. |
fpsunflower
reviewed
Jan 24, 2019
| extension {\cf .HEIC}. | ||
|
|
||
| HEIC compression is lossy, but is higher visual quality than JPEG while | ||
| taking only half the file size. Currently, OIIO's HEIF reader supports |
There was a problem hiding this comment.
Missing the end of this sentence?
There was a problem hiding this comment.
Apparently, yes. Will fix.
fpsunflower
reviewed
Jan 24, 2019
| : heif_chroma_interleaved_RGB; | ||
| m_himage = m_ihandle.decode_image(heif_colorspace_RGB, chroma); | ||
|
|
||
| } catch (const heif::Error& err) { |
There was a problem hiding this comment.
Its a shame that the C++ wrapper for libheif converts error codes into exceptions and that you have to catch the exception to turn it back into an error code ...
|
Other than the docs - LGTM! (the exception observation is more of a rant than a comment, obviously you are stuck with the decision that the |
HEIF is a container for HEIC-compressed images. HEIC is the still image sibling to HEVC video compression. Roughly speaking, it produces lossy compressed images about half the file size of JPEGs but with higher visual quality. At the moment, it's hard to find software that will reliably read heic/heif, except for recent cuts of software within the Apple ecosystem (the only ones I've encountered so far are iPhone camera images). But that will surely change, since it's a superior format to JPEG in many ways. This is the first stab at supporting heif/heic images using the open source libheif. I'm fairly confident in the reading, including exif metadata, of RGB and RGBA images, including files with multiple images. I've not yet figured out depth images. This can also write images (but only single images per file, RGB or RGBA), and although the exif metadata I write can be read again by OIIO's heif reader, Apple's Preview.app does not recognize the metadata for some reason. I don't know why, maybe I'll return to that later. I also want to fix later the limitation of not being able to output multi-image heif files. Along the way, I converted decode_xmp() utility to be based on string_view, and also changed encode_exif() to take an explicit 'endianreq' parameter so it's possible to request a specific endianness. (Apple's Preview.app, which is the main way I was able to test whether I'm writing them correctly, *requires* that the exif be written as big endian, or it won't recognize the file as proper heic at all. So that required some extensive changes in my exif blob code.) The latest release of libheif, 1.3, doesn't fully support color profiles. The in-progress libheif master (future 1.4) does, so I'll add support when that is released. For now, it always looks like sRGB, and that seems to be the common case, but it can be incorrect. Currently, we only will read and write uint8 pixel data. The libheif authors are working on full support for HDR/extended range, but that's not even merged into its master yet. I'll add support in the OIIO heif reader as that gets merged into libheif releases.
|
I could use the C API directly, but the C++ was looked more compact and attractive, and so I was most of the way through implementing it all before I realized how many try/catch blocks I needed. Didn't feel like rewriting the whole thing, wordier, just to eliminate exceptions. |
|
I pushed an update to fix the docs typos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEIF is a container for HEIC-compressed images. HEIC is the still image
sibling to HEVC video compression. Roughly speaking, it produces lossy
compressed images about half the file size of JPEGs but with higher
visual quality.
At the moment, it's hard to find software that will reliably read
heic/heif, except for recent cuts of software within the Apple ecosystem
(the only ones I've encountered so far are iPhone camera images). But
that will surely change, since it's a superior format to JPEG in many
ways.
This is the first stab at supporting heif/heic images using the open
source libheif. I'm fairly confident in the reading, including exif
metadata, of RGB and RGBA images, including files with multiple images.
I've not yet figured out depth images.
This can also write images (but only single images per file, RGB or
RGBA), and although the exif metadata I write can be read again by
OIIO's heif reader, Apple's Preview.app does not recognize the metadata
for some reason. I don't know why, maybe I'll return to that later.
I also want to fix later the limitation of not being able to output
multi-image heif files.
Along the way, I converted decode_xmp() utility to be based on
string_view, and also changed encode_exif() to take an explicit
'endianreq' parameter so it's possible to request a specific
endianness. (Apple's Preview.app, which is the main way I was able to
test whether I'm writing them correctly, requires that the exif be
written as big endian, or it won't recognize the file as proper heic at
all. So that required some extensive changes in my exif blob code.)
The latest release of libheif, 1.3, doesn't fully support color
profiles. The in-progress libheif master (future 1.4) does, so I'll add
support when that is released. For now, it always looks like sRGB, and
that seems to be the common case, but it can be incorrect.
Currently, we only will read and write uint8 pixel data. The libheif
authors are working on full support for HDR/extended range, but that's
not even merged into its master yet. I'll add support in the OIIO heif
reader as that gets merged into libheif releases.