Improve Python error reporting for ImageOutput and IB.set_pixels #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying decoding of pixel value arrays -- used by some of the ImageOutput methods and ImageBuf.set_pixels -- threw exceptions when the pixel array didn't conform to expectations. This led to very confusing behavior, and crashes if the python program didn't carefully catch them. Instead of throwing exceptions, bubble up an error message for the usual OIIO error reporting, so wrongly-shaped pixel data arrays are treated similarly to other kinds of error. Also, detect with a better error message cases where user tries to write scanlines to a tiled file or vice versa -- it was handled well in C++, but the Python would start by parsing the pixel array, then have a confusing error that it was the wrong shape, instead of the more clear error message about using tiles instead of scanlines.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 11, 2019
…demySoftwareFoundation#2127) The underlying decoding of pixel value arrays -- used by some of the ImageOutput methods and ImageBuf.set_pixels -- threw exceptions when the pixel array didn't conform to expectations. This led to very confusing behavior, and crashes if the python program didn't carefully catch them. Instead of throwing exceptions, bubble up an error message for the usual OIIO error reporting, so wrongly-shaped pixel data arrays are treated similarly to other kinds of error. Also, detect with a better error message cases where user tries to write scanlines to a tiled file or vice versa -- it was handled well in C++, but the Python would start by parsing the pixel array, then have a confusing error that it was the wrong shape, instead of the more clear error message about using tiles instead of scanlines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying decoding of pixel value arrays -- used by some of the
ImageOutput methods and ImageBuf.set_pixels -- threw exceptions when
the pixel array didn't conform to expectations. This led to very
confusing behavior, and crashes if the python program didn't carefully
catch them. Instead of throwing exceptions, bubble up an error message
for the usual OIIO error reporting, so wrongly-shaped pixel data arrays
are treated similarly to other kinds of error.
Also, detect with a better error message cases where user tries to write
scanlines to a tiled file or vice versa -- it was handled well in C++,
but the Python would start by parsing the pixel array, then have a
confusing error that it was the wrong shape, instead of the more clear
error message about using tiles instead of scanlines.