Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Crash when reading certain PSD files #4599

Closed
jessey-git opened this issue Jan 17, 2025 · 0 comments · Fixed by #4600
Closed

[BUG] Crash when reading certain PSD files #4599

jessey-git opened this issue Jan 17, 2025 · 0 comments · Fixed by #4600

Comments

@jessey-git
Copy link
Contributor

jessey-git commented Jan 17, 2025 •
edited
Loading

Describe the bug

A crash occurs when reading certain PSD files. Looks like it's due to RLE encoding... PR incoming

OpenImageIO version and dependencies

Two versions were tested:

OIIO 2.5.11.0 | unknown arch?
    Build compiler: MSVS 1929 | C++14/199711
    HW features enabled at build: sse2

And

OIIO 3.1.0.0dev | unknown arch?
    Build compiler: MSVS 1943 | C++17/199711
    HW features enabled at build: sse2,sse3,ssse3,sse41,sse42,avx,avx2

To Reproduce

Steps to reproduce the behavior:

  1. Try reading the attached file using OIIO
  2. Crash inside PSDInput::read_native_scanline

Python repro

import OpenImageIO as oiio
inp = oiio.ImageInput.open("psd-test.psd")

spec = inp.spec()
nchannels = spec.nchannels
pixels = inp.read_image(0, 0, 0, nchannels, "float")  # does not matter if uint16 or uint8 is attempted either

psd-test.zip
jessey-git added a commit to jessey-git/OpenImageIO that referenced this issue Jan 17, 2025
@jessey-git
Fix AcademySoftwareFoundation#4599: Perform endian byteswap on correc…
10abad9 
…t buffer area for PSD RLE decoding
jessey-git added a commit to jessey-git/OpenImageIO that referenced this issue Jan 17, 2025
@jessey-git
Fix AcademySoftwareFoundation#4599: Perform endian byteswap on correc…
bfe3277 
…t buffer area for PSD RLE decoding

Signed-off-by: Jesse Yurkovich <[email protected]>
@jessey-git jessey-git mentioned this issue Jan 17, 2025
Merged
5 tasks
@lgritz lgritz closed this as completed in a50e7c7 Jan 19, 2025
lgritz pushed a commit to lgritz/OpenImageIO that referenced this issue Jan 20, 2025
@jessey-git @lgritz
fix(pdf): Perform endian byteswap on correct buffer area for PSD RLE (A…
740a6ea 
…cademySoftwareFoundation#4600)

Perform the endian byteswap on the correct buffer area for PSD RLE
decoding. The original code used `dst` but that pointer is modified from
its original value as it progresses through decoding.

Fixes AcademySoftwareFoundation#4599 

---------

Signed-off-by: Jesse Yurkovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pdf): Perform endian byteswap on correct buffer area for PSD RLE jessey-git/OpenImageIO
1 participant
@jessey-git