-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Add self-building abilities for more dependencies #4387
Comments
I've actually already done libjpeg-turbo -- was necessary for building with cibuildwheel on the manylinux images. I'll submit a PR for that. |
As requested in #4387. --------- Signed-off-by: Zach Lewis <[email protected]> Signed-off-by: zachlewis <[email protected]>
As requested in AcademySoftwareFoundation#4387. --------- Signed-off-by: Zach Lewis <[email protected]> Signed-off-by: zachlewis <[email protected]>
As requested in #4387. --------- Signed-off-by: Zach Lewis <[email protected]> Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: zachlewis <[email protected]> Co-authored-by: Larry Gritz <[email protected]>
As requested in AcademySoftwareFoundation#4387. --------- Signed-off-by: Zach Lewis <[email protected]> Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: zachlewis <[email protected]> Co-authored-by: Larry Gritz <[email protected]>
As requested in AcademySoftwareFoundation#4387. --------- Signed-off-by: Zach Lewis <[email protected]> Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: zachlewis <[email protected]> Co-authored-by: Larry Gritz <[email protected]>
As requested in AcademySoftwareFoundation#4387. --------- Signed-off-by: Zach Lewis <[email protected]> Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: zachlewis <[email protected]> Co-authored-by: Larry Gritz <[email protected]>
As requested in AcademySoftwareFoundation#4387. --------- Signed-off-by: Zach Lewis <[email protected]> Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: zachlewis <[email protected]> Co-authored-by: Larry Gritz <[email protected]>
I would like to work on GIFlib |
Hi @lgritz |
It's one of the foundational libraries of the web. It must live somewhere, even if that particular location is no longer used. I'm very confident that you will be able to find it. |
Also, make sure it's not just some kind of temporary glitch. When you run dozens of CI tests a day that download dependencies, you learn pretty quickly that any repo out there (or even a huge service like GitHub) will experience a surprising number of glitches and spurious failures to resolve a repo. |
It looks like GIFLIB lives here: https://sourceforge.net/projects/giflib/ There's also a library called GIFLIB-Turbo, supposedly "a faster drop-in replacement for GIFLIB" that may be worth checking out. https://github.com/bitbank2/giflib-turbo |
I'm sorry, I didn't read or think hard enough about your message 3 weeks ago, @hisergiorojas. I should have recognized at the time that the Gitlab link was simply incorrect. That's not where the project lives -- it's on sourceforge. In fact, if you look at our own helper script that our CI uses, OIIO's src/build-scripts/build_gif.bash, you can see that to build giflib from source, it also downloads from sourceforge. @zachlewis: giflib, whatever its shortcomings may be, is one of the most widely used libraries in the known universe, and I think we can take for granted that it's stable and well maintained. Giflib-turbo is conceptually attractive but has only 37 stars, NO tagged releases ever, and seems to go years between source code edits. I have no knowledge that there's anything wrong with it per se, but given how unimportant GIF performance is to typical OIIO users, I think it's a fine project to bookmark and remember in case anything goes seriously wrong with the real giflib in the future, but it seems like switching to it would introduce a bunch of new risks while not solving any legit problems for us. |
We recently added (in PR #4242) the ability for OIIO's CMake build system to automatically download and build certain dependencies if they are not found.
(Note: It doesn't happen by default, it requires
OpenImageIO_BUILD_MISSING_DEPS
to be set to a comma-separated list of deps to self-build (or "all"). Also,OpenImageIO_BUILD_LOCAL_DEPS
can be use to force listed dependencies to be built in this way, even if found.)The original PR #4242 set this up for Imath, OpenEXR, fmt, Robinmap, and OpenColorIO. Subsequent PRs added the self-build ability for Freetype (#4283), libtiff and its libdeflate dependency (#4296), pybind11 (#4297), and improved that of OpenColorIO (#4367).
It would be great to have this ability added for other dependencies! Each can be tackled separately, and each is therefore a fairly self-contained task that doesn't require any prior deep knowledge of the OIIO internals, and could be a good first issue or Dev Days project.
The other high priority dependencies that would be good to add these self-build scripts for are:
If you'd like to work on one of these, just comment below 👇 and say which one you will work on so that two people aren't trying to do the same one. Also feel free to ask below if you have any questions about what needs to be done, where to find examples of the ones that already work, or anything else that would help you get started.
The text was updated successfully, but these errors were encountered: