-
Notifications
You must be signed in to change notification settings - Fork 606
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
oiiotool: attribute actions get subimage controls (#3384)
I realized that --attrib (and several related actions) only set the attribute as directed for the first subimage if it's a multi-image file (such as a multi-part exr), or all of them if the -a flag is used. But there was no ability to set it for a particular (non-first) subimage, like many other oiiotool actions have the ability to do. So in this patch, I refactor the following commands to use the OiiotoolOp and related macros, which automatically make it responsive to the `:subimages=` optional modifiers: --attrib --sattrib --eraseattrib --caption --orientation --clear-keywords --iscolorspace As a bonus aside, one thing this lets you do is set a different compression method per-subimage using, e.g., `--attrib compression:subimages=3 dwaa:100`. But if you set compression with `--attrib compression`, do not also use `--compression`, which will override it and also apply to all subimages.
- Loading branch information
Showing
6 changed files
with
346 additions
and
420 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.