Fix progress count off by one bug.

Signed-off-by: Aaron Colwell <[email protected]>
AcademySoftwareFoundation · Apr 11, 2024 · 40a14bb · 40a14bb
1 parent f43c19a
commit 40a14bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/libOpenImageIO/imagebuf.cpp b/src/libOpenImageIO/imagebuf.cpp
@@ -1448,7 +1448,8 @@ ImageBuf::write(ImageOutput* out, ProgressCallback progress_callback,
                         && progress_callback(
                             progress_callback_data,
                             (float)(z * outspec.height
-                                    + (isDecreasingY ? (outspec.height - y) : y))
+                                    + (isDecreasingY ? (outspec.height - 1 - y)
+                                                     : y))
                                 / (outspec.height * outspec.depth)))
                         return ok;
                 }

diff --git a/src/libOpenImageIO/imageoutput.cpp b/src/libOpenImageIO/imageoutput.cpp
@@ -544,7 +544,7 @@ ImageOutput::write_image(TypeDesc format, const void* data, stride_t xstride,
                     && progress_callback(
                         progress_callback_data,
                         (float)(z * m_spec.height
-                                + (isDecreasingY ? (m_spec.height - y) : y))
+                                + (isDecreasingY ? (m_spec.height - 1 - y) : y))
                             / (m_spec.height * m_spec.depth)))
                     return ok;
             }