Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build GLFW as a static library #1680

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Always build GLFW as a static library #1680

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
327ccf3
force glfw to always build static libraries, regardless of the state …
ld-kerley Jan 29, 2024
f0c82cd
updating glfw target
ld-kerley Jan 29, 2024
6a87622
reverting to 'glfw_minimal'
ld-kerley Jan 30, 2024
5f4a9da
Minor update to comment
jstone-lucasfilm Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/MaterialXGraphEditor/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ set(GLFW_BUILD_TESTS OFF)
set(GLFW_BUILD_DOCS OFF)
set(GLFW_INSTALL OFF)

# Explicitly build GLFW with static libraries, independent of the broader build settings.
set(BUILD_SHARED_LIBS OFF)

add_subdirectory(External/Glfw)

if(MSVC)
Expand Down
Loading