Omit Python data installation in non-Python builds #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmolodo This looks like a good improvement to me, though I should note that there's a larger refactoring of Python builds that has been proposed in #1317, with the goal of supporting automated generation of Python packages for PyPI distribution. We should make sure that these two changes are compatible, but I'd support the idea of merging them both if there are no conflicts. |
…ython Signed-off-by: Jonathan Stone <[email protected]>
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Aug 25, 2023
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…undation#1437) Since the addition of AcademySoftwareFoundation#1237, we now create a python folder, with a copy of the stdlibs, even if we're not building python. This is at best redundant, and in my particular case, caused a problem in a downstream build script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the addition of Include standard data libraries in Python package #1237, we now create a python folder, with a copy of the stdlibs, even if we're not building python.
This is at best redundant, and in my particular case, caused a problem in a downstream build script.
Also - I noticed that the contents of
<INSTALL>/python/MaterialX/librariesmirrors the contents of<INSTALL>/libraries, EXCEPT that<INSTALL>/python/MaterialX/libraries/mdlis missing. Is this intentional? Should we be copying themdlfolder as well?