feat: Abstract-compatible subscription payment system #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@0xObsidian is attempting to deploy a commit to the Abstract Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Description ----------- - SubscriptionRegistry: Manages plans and subscriptions - SubscriptionAccount: Smart wallet for automated payments - Full test coverage. Includes ECDSA validation, reentrancy protection, and OpenZeppelin security features. Usage ----- Please check `README.md`.
0xObsidian
force-pushed
the
0xObsidian/impl-subscription-smart-contract
branch
from
57c82c3 to
0009628
Compare
0xObsidian
changed the title
Description ----------- - Updated .prettierrc config. - Updated Hardhat config to include TypeChain and Ethers plugins. - Improved clean-script to now removes node_modules for a complete reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes ECDSA validation, reentrancy protection, and OpenZeppelin security features.
Available tests
Security Tests Access Control ✔ Should prevent non-owners from creating plans (886ms) ✔ Should prevent non-owners from withdrawing funds ✔ Should prevent non-owners from managing subscriptions Reentrancy Protection ✔ Should prevent reentrant subscription creation ✔ Should prevent reentrant payment processing Payment Security ✔ Should prevent processing payments before due date ✔ Should prevent processing payments for inactive subscriptions ✔ Should prevent processing payments for inactive plans Fund Security ✔ Should prevent withdrawal when balance is zero ✔ Should ensure subscription payments are exact SubscriptionAccount Core Functionality Account Setup ✔ Should have correct owner (66ms) ✔ Should have correct registry Subscription Management ✔ Should allow owner to subscribe to a plan ✔ Should allow owner to cancel subscription Payment Processing ✔ Should process payment successfully SubscriptionRegistry Plan Management ✔ Should create a plan (42ms) ✔ Should revert if interval is zero ✔ Should revert if amount is zero Subscription Management ✔ Should allow subscription to a plan ✔ Should revert if already subscribed ✔ Should allow cancellation of subscription ✔ Should revert cancellation if no active subscription Payment Processing ✔ Should process payment when due Withdrawal ✔ Should allow owner to withdraw funds 24 passing (1s)Usage
Clone this PR branch and check
README.md.