#1465 Helper scripts for the combined job #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianOlosutean
requested review from
benedeki,
dk1844,
DzMakatun,
HuvarVer and
lokm01
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
dk1844
previously approved these changes
Jul 31, 2020
benedeki
reviewed
Aug 2, 2020
README.md
Outdated
| @@ -239,6 +278,8 @@ The list of additional options available for running Conformance: | |||
| | --catalyst-workaround **true/false** | Turns on (`true`) or off (`false`) workaround for Catalyst optimizer issue. It is `true` by default. Turn this off only is you encounter timing freeze issues when running Conformance. | | |||
| | --autoclean-std-folder **true/false** | If `true`, the standardized folder will be cleaned automatically after successful execution of a Conformance job. | | |||
|
|
|||
| All the additional options for Standardization and Conformance can be specified when running the combined StandardizationAndConformance job | |||
There was a problem hiding this comment.
Suggested change
| All the additional options for Standardization and Conformance can be specified when running the combined StandardizationAndConformance job | |
| All the additional options valid for both Standardization and Conformance can be also specified when running the combined StandardizationAndConformance job |
README.md
Outdated
| @@ -197,7 +236,7 @@ The list of options for configuring Spark deployment mode in Yarn and resource s | |||
| For more information on these options see the official documentation on running Spark on Yarn: | |||
| [https://spark.apache.org/docs/latest/running-on-yarn.html](https://spark.apache.org/docs/latest/running-on-yarn.html) | |||
|
|
|||
| The list of all options for running both Standardization and Conformance: | |||
| The list of all options for running Standardization, Conformance and the combined Standardization and Conformance: | |||
There was a problem hiding this comment.
Suggested change
| The list of all options for running Standardization, Conformance and the combined Standardization and Conformance: | |
| The list of all options for running Standardization, Conformance and the combined Standardization And Conformance jobs: |
Zejnilovic
reviewed
Aug 3, 2020
README.md
Outdated
| @@ -39,6 +39,9 @@ This is a Spark job which reads an input dataset in any of the supported formats | |||
| ### Conformance | |||
| This is a Spark job which **applies the Menas-specified conformance rules to the standardized dataset**. | |||
|
|
|||
| ### Standardization and Conformance | |||
| This is a Spark job which executes Standardization and Conformance together | |||
There was a problem hiding this comment.
I would maybe stress a bit more that it runs as one spark job.
|
Kudos, SonarCloud Quality Gate passed!
|
Zejnilovic
approved these changes
Aug 3, 2020
dk1844
approved these changes
Aug 3, 2020
benedeki
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1465