Skip to content

Commit

Permalink
* comments improvement
Browse files Browse the repository at this point in the history
  • Loading branch information
benedeki committed Jan 22, 2021
1 parent 7999644 commit 2391788
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,7 @@ trait CommonJobExecution extends ProjectMetadata {
case Some(version) => version
case None =>

// publishFs for this specific feature (needed for missing reportVersion until reusable
// common "PathConfig" with FS objects is established)
// Since `pathConfig.publish.fileSystem` is not available at this point yet, a temporary publish-FS is create & used here instead
val tempPublishFs: FileSystem = FileSystemUtils.getFileSystemFromPath(dataset.hdfsPublishPath)
val fsUtils = HadoopFsUtils.getOrCreate(tempPublishFs)
val newVersion = fsUtils.getLatestVersion(dataset.hdfsPublishPath, jobConfig.reportDate) + 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,7 @@ class HadoopFsUtils private()(implicit fs: FileSystem) extends DistributedFsUtil
tmpFile.deleteOnExit()
FileUtils.writeByteArrayToFile(tmpFile, content)
tmpFile.getAbsolutePath

// why not use
// fs.copyToLocalFile(false, new Path(hdfsPath), new Path("someLocalName"), true)
//TODO #1645 Possible simplification of this code
}

override def read(distPath: String): String = {
Expand Down

0 comments on commit 2391788

Please sign in to comment.