test: clone with lean returns lean subdocs

AbdelrahmanHafez · Apr 4, 2020 · d9f2a08 · d9f2a08
1 parent 08592a5
commit d9f2a08
Showing 1 changed file with 48 additions and 17 deletions.
diff --git a/test/model.populate.test.js b/test/model.populate.test.js
@@ -8143,30 +8143,61 @@ describe('model: populate:', function() {
     });
   });
 
-  it('can use clone with lean (gh-8760)', function() {
-    const blogPostSchema = new Schema({
-      commentsIds: [{ type: Schema.ObjectId, ref: 'Comment' }]
+  describe('gh-8760', function() {
+    it('can use clone with lean', function() {
+      const blogPostSchema = new Schema({
+        commentsIds: [{ type: Schema.ObjectId, ref: 'Comment' }]
+      });
+
+      const commentSchema = new Schema({ content: String });
+
+      const BlogPost = db.model('BlogPost', blogPostSchema);
+      const Comment = db.model('Comment', commentSchema);
+
+      const comment = new Comment({ content: 'Cool post.' });
+      const blogPost = new BlogPost({ commentsIds: [comment._id] });
+
+      return co(function*() {
+        yield Promise.all([
+          blogPost.save(),
+          comment.save()
+        ]);
+
+        const foundBlogPost = yield BlogPost.findOne({ _id: blogPost._id })
+          .populate({ path: 'commentsIds', options: { clone: true } })
+          .lean();
+
+        assert.equal(foundBlogPost.commentsIds[0].content, 'Cool post.');
+      });
     });
 
-    const commentSchema = new Schema({ content: String });
+    it('clone with populate and lean correctly makes child lean', function() {
+      const isLean = v => v != null && !(v instanceof mongoose.Document);
 
-    const BlogPost = db.model('BlogPost', blogPostSchema);
-    const Comment = db.model('Comment', commentSchema);
+      const blogPostSchema = new Schema({
+        commentsIds: [{ type: Schema.ObjectId, ref: 'Comment' }]
+      });
 
-    const comment = new Comment({ content: 'Cool post.' });
-    const blogPost = new BlogPost({ commentsIds: [comment._id] });
+      const commentSchema = new Schema({ content: String });
 
-    return co(function*() {
-      yield Promise.all([
-        blogPost.save(),
-        comment.save()
-      ]);
+      const BlogPost = db.model('BlogPost', blogPostSchema);
+      const Comment = db.model('Comment', commentSchema);
+
+      const comment = new Comment({ content: 'Cool post.' });
+      const blogPost = new BlogPost({ commentsIds: [comment._id] });
+
+      return co(function*() {
+        yield Promise.all([
+          blogPost.save(),
+          comment.save()
+        ]);
 
-      const foundBlogPost = yield BlogPost.findOne({ _id: blogPost._id })
-        .populate({ path: 'commentsIds', options: { clone: true } })
-        .lean();
+        const foundBlogPost = yield BlogPost.findOne({ _id: blogPost._id })
+          .populate({ path: 'commentsIds', options: { clone: true } })
+          .lean();
 
-      assert.equal(foundBlogPost.commentsIds[0].content, 'Cool post.');
+        assert.ok(isLean(foundBlogPost.commentsIds[0]));
+      });
     });
   });