Import Columns Bug 2427 #2707
Closed
Import Columns Bug 2427 #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(EntityDatatype): enhance `importMapFunction` logic and update type handling with robust matching - Improved `importMapFunction` with better type handling and JSDoc annotations for clarity. - Added normalization logic to handle mismatches between imported values (numbers) and entity fields (strings), ensuring robust matching. - Handles cases where imported values are null or undefined gracefully. - Ensures matching entities in the database are mapped correctly, and undefined is returned for non-matching values without errors. - Refactored the code for improved readability and maintainability: - Introduced `normalizeValue` to standardize value comparison. - Streamlined error handling and entity lookups. - Added detailed unit tests for `importMapFunction`: - Validates mapping to existing entities when values are exact or type-convertible matches. - Ensures undefined is returned for non-matching values. - Covers scenarios for mismatched types between imported and entity field values. - Utilized `mockEntityMapper` to simulate database interactions in tests. - Updated GPLv3 license header and modernized class structure while preserving existing functionality. Enhances the reliability of `EntityDatatype` and ensures consistent behavior during imports and anonymization processes.
sleidig
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks for contributing, @kumarannathan ! Welcome to the Aam Digital community 😃
I have briefly looked over your code and it mostly looks good to me. I haven't tested it in practice yet, however. I made a few remarks for a first iteration for you already.
@george-neha , could you maybe help us test this functionally?
Co-authored-by: Sebastian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(EntityDatatype): enhance
importMapFunctionlogic and update type handling with robust matchingimportMapFunctionwith better type handling and JSDoc annotations for clarity.normalizeValueto standardize value comparison.Enhances the reliability of
EntityDatatypeand ensures consistent behavior during imports and anonymization processes.