Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download stats #70

Merged
merged 8 commits into from
Oct 29, 2021
Merged

Add download stats #70

merged 8 commits into from
Oct 29, 2021

Conversation

zhuoyang125
Copy link

Create a new command download
Able to download userful statistics into a .txt file.
Update user guide to reflect this change.

TODO:

  • Refactor sorting of persons
  • Present stats in more user friendly way

@zhuoyang125 zhuoyang125 added this to the v1.3 milestone Oct 28, 2021
@zhuoyang125 zhuoyang125 requested a review from sherrpass October 28, 2021 18:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #70 (a6419df) into master (82a0399) will decrease coverage by 4.95%.
The diff coverage is 9.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
- Coverage     60.78%   55.83%   -4.96%     
- Complexity      510      511       +1     
============================================
  Files           100      102       +2     
  Lines          1859     2049     +190     
  Branches        222      235      +13     
============================================
+ Hits           1130     1144      +14     
- Misses          673      848     +175     
- Partials         56       57       +1     
Impacted Files Coverage Δ
...va/seedu/siasa/logic/commands/DownloadCommand.java 0.00% <0.00%> (ø)
.../siasa/logic/commands/policy/AddPolicyCommand.java 0.00% <0.00%> (ø)
...gic/commands/policy/ShowExpiringPolicyCommand.java 0.00% <0.00%> (ø)
...ain/java/seedu/siasa/logic/parser/SiasaParser.java 62.50% <0.00%> (-5.69%) ⬇️
...sa/logic/parser/policy/AddPolicyCommandParser.java 0.00% <0.00%> (ø)
src/main/java/seedu/siasa/model/Model.java 100.00% <ø> (ø)
src/main/java/seedu/siasa/model/ModelManager.java 83.78% <0.00%> (-2.33%) ⬇️
src/main/java/seedu/siasa/model/Siasa.java 58.06% <0.00%> (-12.53%) ⬇️
...ava/seedu/siasa/model/policy/UniquePolicyList.java 74.07% <0.00%> (-12.89%) ⬇️
src/main/java/seedu/siasa/model/tag/Tag.java 80.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb7087...a6419df. Read the comment docs.

@sherrpass
Copy link

LGTM!

@sherrpass sherrpass merged commit 0d7709e into master Oct 29, 2021
@sherrpass sherrpass linked an issue Oct 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output stats and data
3 participants