Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication for common fields in expiring cmd, refactor msg #185

Merged
merged 2 commits into from
Nov 7, 2021

Conversation

sherrpass
Copy link

  1. Updated command messages and UG to include expired policies
  2. Decrease duplicated constants between showexpiringpolicies and showexpiringpoliciessummary commands

@sherrpass sherrpass requested a review from a team November 7, 2021 03:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #185 (bfa2bbc) into master (dfbc77d) will decrease coverage by 0.23%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #185      +/-   ##
============================================
- Coverage     54.84%   54.61%   -0.24%     
- Complexity      556      562       +6     
============================================
  Files           107      107              
  Lines          2281     2298      +17     
  Branches        282      287       +5     
============================================
+ Hits           1251     1255       +4     
- Misses          933      944      +11     
- Partials         97       99       +2     
Impacted Files Coverage Δ
...mands/policy/ShowExpiringPolicySummaryCommand.java 42.85% <0.00%> (-3.81%) ⬇️
...gic/commands/policy/ShowExpiringPolicyCommand.java 37.50% <100.00%> (ø)
...ava/seedu/siasa/model/policy/UniquePolicyList.java 71.42% <0.00%> (-2.65%) ⬇️
...va/seedu/siasa/logic/commands/DownloadCommand.java 1.96% <0.00%> (-0.17%) ⬇️
...in/java/seedu/siasa/commons/util/CurrencyUtil.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbc77d...bfa2bbc. Read the comment docs.

@sherrpass sherrpass linked an issue Nov 7, 2021 that may be closed by this pull request
Copy link

@yatbun yatbun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardising of output messages

Copy link

@yatbun yatbun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yatbun yatbun merged commit 4b5243a into master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message for expiring policy can be modified slightly
3 participants