Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zhuoyang change commission to double #184

Merged
merged 5 commits into from
Nov 7, 2021

Conversation

zhuoyang125
Copy link

increase the range of commission to avoid overflow errors

@zhuoyang125 zhuoyang125 added this to the v1.4 milestone Nov 6, 2021
@zhuoyang125 zhuoyang125 requested a review from a team November 6, 2021 17:28
@zhuoyang125 zhuoyang125 self-assigned this Nov 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #184 (f6caa4c) into master (dfbc77d) will increase coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #184      +/-   ##
============================================
+ Coverage     54.84%   54.98%   +0.14%     
  Complexity      556      556              
============================================
  Files           107      107              
  Lines          2281     2275       -6     
  Branches        282      281       -1     
============================================
  Hits           1251     1251              
+ Misses          933      927       -6     
  Partials         97       97              
Impacted Files Coverage Δ
...in/java/seedu/siasa/commons/util/CurrencyUtil.java 0.00% <0.00%> (ø)
...va/seedu/siasa/logic/commands/DownloadCommand.java 2.32% <0.00%> (+0.19%) ⬆️
src/main/java/seedu/siasa/model/Model.java 100.00% <ø> (ø)
src/main/java/seedu/siasa/model/ModelManager.java 74.69% <ø> (ø)
src/main/java/seedu/siasa/model/Siasa.java 42.85% <0.00%> (ø)
...ava/seedu/siasa/model/policy/UniquePolicyList.java 78.43% <0.00%> (+4.35%) ⬆️
src/main/java/seedu/siasa/ui/GuideWindow.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbc77d...f6caa4c. Read the comment docs.

@sherrpass
Copy link

LGTM!

@sherrpass
Copy link

Isn't download supposed to create a csv file? Maybe we can look into creating a separate issue and pr for this.

@sherrpass sherrpass merged commit 264270c into master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants