Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zhuoyang display user guide images in jar #183

Merged
merged 4 commits into from
Nov 6, 2021

Conversation

zhuoyang125
Copy link

No description provided.

@zhuoyang125 zhuoyang125 added this to the v1.4 milestone Nov 6, 2021
@zhuoyang125 zhuoyang125 requested a review from a team November 6, 2021 16:16
@zhuoyang125 zhuoyang125 self-assigned this Nov 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #183 (a540978) into master (7436675) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #183      +/-   ##
============================================
- Coverage     54.86%   54.84%   -0.03%     
  Complexity      556      556              
============================================
  Files           107      107              
  Lines          2280     2281       +1     
  Branches        282      282              
============================================
  Hits           1251     1251              
- Misses          932      933       +1     
  Partials         97       97              
Impacted Files Coverage Δ
src/main/java/seedu/siasa/ui/GuideWindow.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7436675...a540978. Read the comment docs.

Copy link

@meerian meerian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice fix

@meerian meerian merged commit dfbc77d into master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants